Skip to content

3595 terminology changes inline with w3c standards - #328

Merged
ChrisChinchilla merged 10 commits into
sdk-v1from
3595-terminology-changes-inline-with-w3c-standards
Sep 19, 2024
Merged

3595 terminology changes inline with w3c standards#328
ChrisChinchilla merged 10 commits into
sdk-v1from
3595-terminology-changes-inline-with-w3c-standards

Conversation

@ChrisChinchilla

@ChrisChinchillaChrisChinchilla commented Sep 5, 2024

Copy link
Copy Markdown

fixes KILTProtocol/ticket#3595

Chris Chinchilla added 2 commits September 5, 2024 17:23
Chris Chinchilla
Term changes
a19972a
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Chris Chinchilla
Code paths
bc697bc
Signed-off-by: Chris Chinchilla <chris@kilt.io>
rflechtner
rflechtner reviewed Sep 9, 2024
View reviewed changes
Comment threadcode_examples/sdk_examples/package.json
Comment threadcode_examples/sdk_examples/src/workshop/issuer/generateAccount.ts
Comment threadconcepts/05_credentials/01_overview.md Outdated
Comment threadconcepts/05_credentials/01_overview.md Outdated
Comment threadconcepts/05_credentials/01_overview.md Outdated
Comment threadconcepts/05_credentials/01_overview.md Outdated
Comment threadconcepts/05_credentials/01_overview.md Outdated
Comment threadconcepts/05_credentials/01_overview.md Outdated
Comment threaddevelop/08_opendid/06_advanced.md
"requirements": [{
"cTypeHash":"0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac",
"trustedAttesters": [
"trustedIssuers": [

@rflechtnerrflechtnerSep 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this relates to a configuration of openDid and shouldn't be changed without changing the openDid code base first

Comment threadstatic/img/concepts/distributed_trust/delegation-hierarchies-dark.svg
@rflechtner

rflechtner commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

the language changes make sense to me, but there's a few changes that don't seem right - like lots of packages being downgraded (including the sdk from v1 to 0.35.0), some other reverts back to code we had in v0, and some renames that shouldn't have happened

Chris Chinchillaand others added 7 commits September 19, 2024 13:22
Chris Chinchilla@rflechtner
Update concepts/05_credentials/01_overview.md
a028c98
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update concepts/05_credentials/01_overview.md
c2c5345
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update concepts/05_credentials/01_overview.md
9105b60
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update concepts/05_credentials/01_overview.md
da14f21
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update concepts/05_credentials/01_overview.md
d5c351b
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update concepts/05_credentials/01_overview.md
8a4e78e
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla
Fix SVGs
694a48d
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
ChrisChinchilla marked this pull request as ready for review September 19, 2024 12:00
@ChrisChinchilla
ChrisChinchilla merged commit e22a09c into sdk-v1Sep 19, 2024
@ChrisChinchilla
ChrisChinchilla deleted the 3595-terminology-changes-inline-with-w3c-standards branch September 19, 2024 12:03
@ChrisChinchilla
ChrisChinchilla restored the 3595-terminology-changes-inline-with-w3c-standards branch September 19, 2024 12:03
@ChrisChinchilla
ChrisChinchilla deleted the 3595-terminology-changes-inline-with-w3c-standards branch September 19, 2024 12:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rflechtnerrflechtnerrflechtner left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisChinchilla@rflechtner