Skip to content

Update workshop to v1 of SDK - #330

Merged
ChrisChinchilla merged 19 commits into
sdk-v1from
3594-update-workshop
Oct 31, 2024
Merged

Update workshop to v1 of SDK#330
ChrisChinchilla merged 19 commits into
sdk-v1from
3594-update-workshop

Conversation

@ChrisChinchilla

@ChrisChinchillaChrisChinchilla commented Oct 24, 2024

Copy link
Copy Markdown

fixes KILTProtocol/ticket#3594

Chris Chinchilla added 4 commits September 30, 2024 12:38
Chris Chinchilla
Draft
940a7eb
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Chris Chinchilla
Draft
fb062a6
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Chris Chinchilla
Draft
7c73f85
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Chris Chinchilla
Draft
37b8ab0
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
ChrisChinchilla changed the base branch from master to sdk-v1October 24, 2024 15:03
rflechtner
rflechtner reviewed Oct 28, 2024
View reviewed changes
Comment threadcode_examples/sdk_examples/src/getFunds.ts
rflechtner
rflechtner reviewed Oct 28, 2024
View reviewed changes
Comment threadcode_examples/sdk_examples/src/workshop/issuer/generateAccount.ts Outdated
Comment threadsdk/02_tutorial/01_welcome.md Outdated
Comment threadsdk/02_tutorial/03_overview.md Outdated
Comment threadsdk/02_tutorial/03_overview.md Outdated
Comment threadsdk/02_tutorial/03_overview.md Outdated
Comment threadsdk/02_tutorial/06_holder/02_create_presentation.md Outdated
Comment threadsdk/02_tutorial/06_holder/index.md Outdated
Comment threadsdk/02_tutorial/07_verification.md Outdated
Comment threadsdk/02_tutorial/07_verification.md Outdated
Comment threadsdk/02_tutorial/07_verification.md Outdated
Chris Chinchillaand others added 10 commits October 29, 2024 09:18
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/01_welcome.md
e2cfded
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla
Update sdk/02_tutorial/03_overview.md
ebb2d9a
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/06_holder/02_create_presentation.md
8bafdae
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/07_verification.md
7ad3d45
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/05_issuer/index.md
54bac00
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla
Update sdk/02_tutorial/05_issuer/03_issue_credential.md
7c939a6
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/06_holder/02_create_presentation.md
3195f50
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/06_holder/02_create_presentation.md
6101763
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla
Changes from review
ef4695e
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Chris Chinchilla
Merge branch '3594-update-workshop' of github.com:KILTprotocol/docs i…
19b02d5
…nto 3594-update-workshop
Signed-off-by: Chris Chinchilla <chris@kilt.io>
# Conflicts:
#	sdk/02_tutorial/03_overview.md
Chris Chinchilla
Changes from review
58dbf0e
Signed-off-by: Chris Chinchilla <chris@kilt.io>
rflechtner
rflechtner reviewed Oct 29, 2024
View reviewed changes

@rflechtnerrflechtner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some nitpicks remaining

Comment threadsdk/02_tutorial/05_issuer/03_issue_credential.md Outdated
Comment threadsdk/02_tutorial/06_holder/02_create_presentation.md Outdated
Comment threadsdk/02_tutorial/07_verification.md Outdated
Comment threadsdk/02_tutorial/07_verification.md Outdated
Chris Chinchillaand others added 4 commits October 31, 2024 10:42
Chris Chinchilla
Update sdk/02_tutorial/05_issuer/03_issue_credential.md
c4874d8
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/06_holder/02_create_presentation.md
fa9dfe2
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla@rflechtner
Update sdk/02_tutorial/07_verification.md
a827c65
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Chris Chinchilla
Update sdk/02_tutorial/07_verification.md
020ebe8
@ChrisChinchilla
ChrisChinchilla marked this pull request as ready for review October 31, 2024 09:44
@ChrisChinchilla

ChrisChinchilla commented Oct 31, 2024

Copy link
Copy Markdown
Author

@rflechtner If you're good with it now, let's get this merged into the SDK branch and I will fix the code transclusion now.

rflechtner
rflechtner approved these changes Oct 31, 2024
View reviewed changes

@rflechtnerrflechtner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@ChrisChinchilla
ChrisChinchilla merged commit 232c02b into sdk-v1Oct 31, 2024
@ChrisChinchilla
ChrisChinchilla deleted the 3594-update-workshop branch October 31, 2024 12:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rflechtnerrflechtnerrflechtner approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisChinchilla@rflechtner