Uh oh!
There was an error while loading. Please reload this page.
chore: cleanup chainspecs - #643
Conversation
Ad96el
left a comment
There was a problem hiding this comment.
Nice changes. We got rid of a lot of dead code. I tried running the node, but it results in an error.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Ad96el
left a comment
There was a problem hiding this comment.
LGTM. The commands are running
Fixeshttps://github.com/KILTprotocol/ticket/issues/3404. Cleaning up the different chainspecs required also the modules to be restructured a bit. To note is the following: * Removal of the `--runtime` flag. Now any possible runtime is parsed solely from the provided `--chain` (or `--dev`) parameter (relevant for starting up the node going forward) * Removal of the unused chainspecs and renaming of the folder (relevant for starting up the node going forward) * Removal of all maintain scripts, which can be re-added if needed * Removal of the clone runtime Of interest is the change from this ```rust match (id, runtime) { ("clone-dev", _) => Ok(Box::new(chain_spec::clone::get_chain_spec_dev()?)), ("clone-new", _) => Ok(Box::new(chain_spec::clone::new_chain_spec()?)), ("dev", _) => Ok(Box::new(chain_spec::peregrine::get_chain_spec_dev()?)), ("spiritnet-dev", _) => Ok(Box::new(chain_spec::spiritnet::get_chain_spec_dev()?)), ("peregrine-new", _) => Ok(Box::new(chain_spec::peregrine::make_new_spec()?)), ("rilt-new", _) => Ok(Box::new(chain_spec::peregrine::get_chain_spec_rilt()?)), ("rilt", _) => Ok(Box::new(chain_spec::peregrine::load_rilt_spec()?)), ("spiritnet", _) => Ok(Box::new(chain_spec::spiritnet::load_spiritnet_spec()?)), ("", "spiritnet") => Ok(Box::new(chain_spec::spiritnet::get_chain_spec_dev()?)), ("", "peregrine") => Ok(Box::new(chain_spec::peregrine::get_chain_spec_dev()?)), (path, "spiritnet") => Ok(Box::new(chain_spec::spiritnet::ChainSpec::from_json_file(path.into())?)), (path, "peregrine") => Ok(Box::new(chain_spec::peregrine::ChainSpec::from_json_file(path.into())?)), (path, "clone") => Ok(Box::new(chain_spec::clone::ChainSpec::from_json_file(path.into())?)), _ => Err("Unknown KILT parachain spec".to_owned()), } ``` to this ```rust match s { // Peregrine development "dev" => Ok(Self::Peregrine(PeregrineRuntime::Dev)), // New blank Peregrine chainspec "peregrine-new" => Ok(Self::Peregrine(PeregrineRuntime::New)), // Peregrine chainspec "peregrine" => Ok(Self::Peregrine(PeregrineRuntime::Peregrine)), // Peregrine staging chainspec "peregrine-stg" => Ok(Self::Peregrine(PeregrineRuntime::PeregrineStg)), // RILT chainspec "rilt" => Ok(Self::Peregrine(PeregrineRuntime::Rilt)), // Any other Peregrine-based chainspec s if s.contains("peregrine") => Ok(Self::Peregrine(PeregrineRuntime::Other(s.to_string()))), // Spiritnet development "spiritnet-dev" => Ok(Self::Spiritnet(SpiritnetRuntime::Dev)), // New blank Spiritnet chainspec "spiritnet-new" => Ok(Self::Spiritnet(SpiritnetRuntime::New)), // Spiritnet chainspec "spiritnet" => Ok(Self::Spiritnet(SpiritnetRuntime::Spiritnet)), // Any other Spiritnet-based chainspec s if s.contains("spiritnet") => Ok(Self::Spiritnet(SpiritnetRuntime::Other(s.to_string()))), _ => Err(format!("Unknown chainspec id provided: {s}")), } ```
Fixeshttps://github.com/KILTprotocol/ticket/issues/3404. Cleaning up the different chainspecs required also the modules to be restructured a bit. To note is the following: * Removal of the `--runtime` flag. Now any possible runtime is parsed solely from the provided `--chain` (or `--dev`) parameter (relevant for starting up the node going forward) * Removal of the unused chainspecs and renaming of the folder (relevant for starting up the node going forward) * Removal of all maintain scripts, which can be re-added if needed * Removal of the clone runtime Of interest is the change from this ```rust match (id, runtime) { ("clone-dev", _) => Ok(Box::new(chain_spec::clone::get_chain_spec_dev()?)), ("clone-new", _) => Ok(Box::new(chain_spec::clone::new_chain_spec()?)), ("dev", _) => Ok(Box::new(chain_spec::peregrine::get_chain_spec_dev()?)), ("spiritnet-dev", _) => Ok(Box::new(chain_spec::spiritnet::get_chain_spec_dev()?)), ("peregrine-new", _) => Ok(Box::new(chain_spec::peregrine::make_new_spec()?)), ("rilt-new", _) => Ok(Box::new(chain_spec::peregrine::get_chain_spec_rilt()?)), ("rilt", _) => Ok(Box::new(chain_spec::peregrine::load_rilt_spec()?)), ("spiritnet", _) => Ok(Box::new(chain_spec::spiritnet::load_spiritnet_spec()?)), ("", "spiritnet") => Ok(Box::new(chain_spec::spiritnet::get_chain_spec_dev()?)), ("", "peregrine") => Ok(Box::new(chain_spec::peregrine::get_chain_spec_dev()?)), (path, "spiritnet") => Ok(Box::new(chain_spec::spiritnet::ChainSpec::from_json_file(path.into())?)), (path, "peregrine") => Ok(Box::new(chain_spec::peregrine::ChainSpec::from_json_file(path.into())?)), (path, "clone") => Ok(Box::new(chain_spec::clone::ChainSpec::from_json_file(path.into())?)), _ => Err("Unknown KILT parachain spec".to_owned()), } ``` to this ```rust match s { // Peregrine development "dev" => Ok(Self::Peregrine(PeregrineRuntime::Dev)), // New blank Peregrine chainspec "peregrine-new" => Ok(Self::Peregrine(PeregrineRuntime::New)), // Peregrine chainspec "peregrine" => Ok(Self::Peregrine(PeregrineRuntime::Peregrine)), // Peregrine staging chainspec "peregrine-stg" => Ok(Self::Peregrine(PeregrineRuntime::PeregrineStg)), // RILT chainspec "rilt" => Ok(Self::Peregrine(PeregrineRuntime::Rilt)), // Any other Peregrine-based chainspec s if s.contains("peregrine") => Ok(Self::Peregrine(PeregrineRuntime::Other(s.to_string()))), // Spiritnet development "spiritnet-dev" => Ok(Self::Spiritnet(SpiritnetRuntime::Dev)), // New blank Spiritnet chainspec "spiritnet-new" => Ok(Self::Spiritnet(SpiritnetRuntime::New)), // Spiritnet chainspec "spiritnet" => Ok(Self::Spiritnet(SpiritnetRuntime::Spiritnet)), // Any other Spiritnet-based chainspec s if s.contains("spiritnet") => Ok(Self::Spiritnet(SpiritnetRuntime::Other(s.to_string()))), _ => Err(format!("Unknown chainspec id provided: {s}")), } ```
Fixeshttps://github.com/KILTprotocol/ticket/issues/3404.
Cleaning up the different chainspecs required also the modules to be restructured a bit. To note is the following:
--runtimeflag. Now any possible runtime is parsed solely from the provided--chain(or--dev) parameter (relevant for starting up the node going forward)Of interest is the change from this
to this