Skip to content

feat: Ismp - #888

Merged
Ad96el merged 24 commits into
chore/polkadot-1.8.0from
ismp
May 16, 2025
Merged

feat: Ismp#888
Ad96el merged 24 commits into
chore/polkadot-1.8.0from
ismp

Conversation

@Ad96el

@Ad96elAd96el commented May 13, 2025

Copy link
Copy Markdown
Contributor

Implements ISMP related pallet

@Ad96elAd96el changed the title Ismpfeat: IsmpMay 15, 2025
@Ad96elAd96el added the ci-skip-docs-pr ci-skip-docs-pr label May 15, 2025

@abdulmthabdulmth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

let deps = crate::rpc::FullDeps {
client: Arc::clone(&client),
pool: Arc::clone(&transaction_pool),
backend: Arc::clone(&backend),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add ismp-parachain-inherent to thecreate_inherent_providers in AuraParams
guide: https://docs.hyperbridge.network/developers/polkadot/ismp-parachain-inherent

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadruntimes/peregrine/src/ismp.rs Outdated

impl pallet_token_gateway::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type Dispatcher = Ismp;

@Wizdave97Wizdave97May 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dispatcher should be pallet-hyperbridge

Suggested change
typeDispatcher = Ismp;
typeDispatcher = Hyperbridge;

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wizdave97Wizdave97 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed Extras in your runtime must be an exact match of what is described in the link below
https://docs.hyperbridge.network/developers/polkadot/pallet-ismp#signed-extensions

Enable offchain indexing in your node by default, follow the guide below:
https://docs.hyperbridge.network/developers/polkadot/pallet-ismp#offchain-indexing

Comment threadruntimes/peregrine/Cargo.toml Outdated
pallet-ismp = { workspace = true, features = ["unsigned"] }
pallet-ismp-runtime-api = { workspace = true }
pallet-token-gateway = { workspace = true }
sp-mmr-primitives = { workspace = true }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sp-mmr-primitives = { workspace = true }

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wizdave97

Copy link
Copy Markdown

Hyperbridge Para Id on testnet is 4009

@Ad96el

Copy link
Copy Markdown
ContributorAuthor

@Wizdave97 Thanks for the review 🙌

Much appreciated! I’ve addressed all your comments.
Indexing is enabled in f57e137, and I double-checked that the signedExtras match exactly.
I also updated the para_id of the test chain.

@Wizdave97

Copy link
Copy Markdown

Looks Good

@Ad96el
Ad96el merged commit 147fdde into chore/polkadot-1.8.0May 16, 2025
@Ad96el
Ad96el deleted the ismp branch May 16, 2025 13:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-skip-docs-prci-skip-docs-pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Ad96el@Wizdave97@abdulmth