Uh oh!
There was an error while loading. Please reload this page.
Add grpcio-tools - #1552
Conversation
rosbo
commented
Jun 24, 2026
Can you add a simple smoke test under the tests forder for the grpcio-tools package for the method you are using to ensure we don't regress: docker-python/tests/test_pandas.py Lines 1 to 9 in 8cc47ea |
SohierDane
commented
Jun 24, 2026
@rosbo I've added the smoke test. Thanks for the recommendation; it caught that the grpcio-tools installation needed to happen in a different location due to the way protobuf is reinstalled. |
| self.assertTrue(hasattr(ping_pb2_grpc, "PingServiceStub")) | ||
| self.assertTrue(hasattr(ping_pb2_grpc, "PingServiceServicer")) | ||
| finally: | ||
| sys.path.remove(tmpdir) |
There was a problem hiding this comment.
this line is redundat.
Given you are using a tempfile.TemporaryDirectory(), it should delete the directory after the "with" claude exits.
There was a problem hiding this comment.
Ack. I removed that call and the now-pointless try/finally.
Uh oh!
There was an error while loading. Please reload this page.
Add a dependency on
grpcio-toolsso we can recompile proto stubs in real time for kaggle_evaluation. It's a small library (<3 MB) and for my purposes the exact version doesn't much matter so I'm hoping this isn't a controversial addition. We do have alternatives if this addition isn't feasible but they're much more invasive, most likely migrating from gRPC to HTTP.