translated “you’ve earned {int} XP” - #398
Merged
Merged
Conversation
Contributor
Author
tombettany
reviewed
Feb 24, 2017
| $scope.id = $routeParams.id; | ||
| $scope.worldId = $routeParams.world; | ||
|
|
||
| $scope.offline = $rootScope.cfg.OFFLINE; |
Contributor
Author
There was a problem hiding this comment.
Yes, it's used to determine which success message to show. There are lots of conditionals already in the view which turn different components on or off, but for some reason only the "Is this online or on the kit?" conditional was being handled in the controller... so by adding this to scope i moved that conditional to the view which makes it easier to translate the success message
Contributor
|
👍 |
tombettany
approved these changes
Feb 24, 2017
paulvarache
pushed a commit
that referenced
this pull request
May 6, 2019
translated “you’ve earned {int} XP”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://trello.com/c/brviHr6m/98-make-art-end-of-challenges-it-says-you-earned-7xp-that-is-not-translated