Skip to content

build: Update required CMake version to 3.28.3 - #1975

Open
charles-lunarg wants to merge 3 commits into
KhronosGroup:mainfrom
charles-lunarg:update_cmake_version
Open

build: Update required CMake version to 3.28.3#1975
charles-lunarg wants to merge 3 commits into
KhronosGroup:mainfrom
charles-lunarg:update_cmake_version

Conversation

@charles-lunarg

@charles-lunargcharles-lunarg commented Jul 15, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Also removed workarounds for older CMake versions.

FYI @JP42

Edit: Pinged the wrong person, apologies

@ci-tester-lunarg

ci-tester-lunarg commented Jul 15, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 41691.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 15, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 41708.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 15, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 41757.

@charles-lunarg

charles-lunarg commented Jul 15, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@jpr42

@charles-lunarg

charles-lunarg commented Jul 15, 2026

Copy link
Copy Markdown
CollaboratorAuthor

CI failure is due to older CMake version. Will have to audit and update CI machines before this can be merged.

CMake 3.28.3 or higher is required. You are running version 3.24.2

@ci-tester-lunarg

ci-tester-lunarg commented Jul 15, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3640 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 15, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3640 failed.

jpr42
jpr42 suggested changes Aug 4, 2026
View reviewed changes
Comment threadCMakeLists.txt

@jpr42jpr42Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highly recommend adding this as the standard way for package managers to disable warnings as errors while keeping life simple for devs

# https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html
# Override at the command line with --compile-no-warning-as-error
set(CMAKE_COMPILE_WARNING_AS_ERROR ON)

Comment threadCMakeLists.txt Outdated
@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 68813.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3684 running.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 68831.

@charles-lunarg
build: Update required CMake version to 3.28.3
139ce87
Also removed workarounds for older CMake versions.
@charles-lunarg
ci: Bring Ubuntu versions forward
d33fbcf
Updates github actions to use Ubuntu 26.
@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 68832.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3686 running.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3686 failed.

@charles-lunarg

charles-lunarg commented Aug 6, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Errors are expected as the CI machine(s) are not all updated to 3.28 yet.

@charles-lunarg
Make use of CMAKE_COMPILE_WARNING_AS_ERROR
dc9f9ee
CMake now offers a mechanism to enable compiler warnings as errors with
ease. BUILD_WERROR is now implemented in terms of this new mechanism.
@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 69055.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 69072.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3688 running.

@ci-tester-lunarg

ci-tester-lunarg commented Aug 6, 2026

Copy link
Copy Markdown

CI Vulkan-Loader build # 3688 failed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jpr42jpr42jpr42 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charles-lunarg@ci-tester-lunarg@jpr42