Uh oh!
There was an error while loading. Please reload this page.
Update 01_Image_view_and_sampler.adoc - #271
Open
oskarTom wants to merge 2 commits into
Open
Conversation
Removed some fields which appear early but are introduced only later in the text.
SaschaWillems
commented
Jan 9, 2026
Collaborator
Not sure if we need addressModeW. The tutorial only ever uses 2D images, so a value for this field doesn't do anything. |
Removed .addressModeW flags
oskarTom
commented
Jan 10, 2026
ContributorAuthor
Yeah, probably not. It was included in two out of three code blocks so I had added it to the one where it was missing. I have now removed it from all three blocks. |
|
asuessenbach
left a comment
Contributor
There was a problem hiding this comment.
Maybe you should rebase your PR with the current state. This file has changed substantially, long before you uploaded your PR.
Moreover, if you change code snippets in the docu, you should probably change the corresponding actual code in the cpp file as well.
| ---- | ||
| vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .mipmapMode = vk::SamplerMipmapMode::eLinear, | ||
| .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat}; | ||
| vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, |
Contributor
There was a problem hiding this comment.
Why do you remove the .mipmapMode ?
| vk::PhysicalDeviceProperties properties = physicalDevice.getProperties(); | ||
| vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .mipmapMode = vk::SamplerMipmapMode::eLinear, | ||
| .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat, | ||
| vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed some fields which appear early but are introduced only later in the text.
Added a missing .addressModeW field