Skip to content

fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AshishBhattarai merged 3 commits into from
Apr 8, 2026
Merged

fix(masks): use luminosity mask by default - CU-86c97q74b #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7317757
use luminosity mask by default
AshishBhattarai Apr 7, 2026
2e46a66
Define backdrop for mask
AshishBhattarai Apr 8, 2026
a82967d
update d.ts
AshishBhattarai Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/icc_profile.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
// store profiles as data and create spaces later?
constructor(label, data, channels, alternate) {
constructor(label, data, channels, alternate, type) {
this.label = label;
this.data = data;
this.channels = channels;
this.alternate = alternate;
this.ref = null;
this.streamRef = null;
this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
}

embed(document) {
Expand Down
4 changes: 2 additions & 2 deletions lib/mixins/color_space.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
this._colorProfiles = {};
},

iccProfile(label, data, channels, alternate) {
const profile = new ICCProfile(label, data, channels, alternate);
iccProfile(label, data, channels, alternate, type) {
const profile = new ICCProfile(label, data, channels, alternate, type);
profile.embed(this);
this._colorProfiles[label] = profile;
Comment on lines +8 to 11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.

Copilot uses AI. Check for mistakes.
return this;
Expand Down
37 changes: 32 additions & 5 deletions lib/write_svg.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
doc.page.xobjects[group.name] = group.xobj;
doc.addContent('/' + group.name + ' Do');
}
function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
Type: 'ExtGState',
CA: 1,
ca: 1,
Comment on lines +692 to 697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).

Copilot uses AI. Check for mistakes.
Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
doc.page.ext_gstates[name] = gstate;
doc.addContent('/' + name + ' gs');
}
function docApplyMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
// backdrop should be black
let bc = [0, 0, 0];
if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
bc = [1, 1, 1, 1];
}
const gstate = doc.ref({
Type: 'ExtGState',
CA: 1,
ca: 1,
BM: 'Normal',
SMask: {
S: 'Luminosity',
G: group.xobj,
BC: bc,
},
});
gstate.end();
doc.page.ext_gstates[name] = gstate;
doc.addContent('/' + name + ' gs');
}
function applyBlendMode(group, blendMode) {
// map svg blendMode to pdf
const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
this.drawChildren(true, false);
doc.restore();
docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
};
};

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
if (this.attr('maskContentUnits') === 'objectBoundingBox') {
doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
}
const maskType = this.attr('mask-type') ?? 'luminance';
this.clip();
this.drawChildren(false, true);
doc.restore();
docEndGroup(group);
docApplyMask(group);
if (maskType === 'alpha') {
docApplyAlphaMask(group);
} else {
docApplyMask(group);
}
Comment on lines +3346 to +3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.

Copilot uses AI. Check for mistakes.
};
};

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
"document",
"vector"
],
"version": "0.17.56",
"version": "0.17.58",
"homepage": "http://pdfkit.org/",
"author": {
"name": "Devon Govett",
Expand Down
3 changes: 2 additions & 1 deletion types/pdfkit.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
data: Uint8Array | Buffer;
channels: number;
alternate: string | string[];
type?: 'cmyk' | 'rgb'
}
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
}

interface PDFColorSpace {
iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
}

interface PDFOutputIntent {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(masks): use luminosity mask by default - CU-86c97q74b by AshishBhattarai · Pull Request #2 · Kittl/pdfkit · GitHub
Skip to content
fix(masks): use luminosity mask by default - CU-86c97q74b#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AshishBhattarai
merged 3 commits into

from

Apr 8, 2026
 Merged


fix(masks): use luminosity mask by default - CU-86c97q74b
#2
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
7317757

use luminosity mask by default


AshishBhattarai Apr 7, 2026
2e46a66

Define backdrop for mask


AshishBhattarai Apr 8, 2026
a82967d

update d.ts


AshishBhattarai Apr 8, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
lib/icc_profile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
class ICCProfile {
 // store profiles as data and create spaces later?
 constructor(label, data, channels, alternate) {
 constructor(label, data, channels, alternate, type) {
 this.label = label;
 this.data = data;
 this.channels = channels;
 this.alternate = alternate;
 this.ref = null;
 this.streamRef = null;
 this.type = type ?? (channels === 4 ? 'cmyk' : 'rgb');
 }

 embed(document) {
Expand Down

4 changes: 2 additions & 2 deletions
lib/mixins/color_space.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,8 @@ export default {
 this._colorProfiles = {};
 },

 iccProfile(label, data, channels, alternate) {
 const profile = new ICCProfile(label, data, channels, alternate);
 iccProfile(label, data, channels, alternate, type) {
 const profile = new ICCProfile(label, data, channels, alternate, type);
 profile.embed(this);
 this._colorProfiles[label] = profile;

Comment on lines

+8
 to 
11

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public iccProfile(...) API now accepts a new type parameter, but the TypeScript declarations still expose only 4 parameters (see types/pdfkit.d.ts). Please update the .d.ts signature to keep the public API consistent for typed consumers.
Copilot uses AI. Check for mistakes.

 return this;
Expand Down

37 changes: 32 additions & 5 deletions
lib/write_svg.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -689,9 +689,9 @@ export default function (doc, svg, x, y, options) {
 doc.page.xobjects[group.name] = group.xobj;
 doc.addContent('/' + group.name + ' Do');
 }
 function docApplyMask(group) {
let name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
let gstate = doc.ref({
 function docApplyAlphaMask(group) {
const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,

Comment on lines

+692
 to 
697

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside docApplyAlphaMask, the inline comment We only support alpha mask for now has become misleading now that luminosity masks are also supported via docApplyMask. Please reword it to clarify this helper applies an alpha SMask specifically (rather than implying alpha is the only supported mask mode overall).
Copilot uses AI. Check for mistakes.

Expand All@@ -706,6 +706,28 @@ export default function (doc, svg, x, y, options) {
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function docApplyMask(group) {
 const name = 'M' + (doc._maskCount = (doc._maskCount || 0) + 1);
 // backdrop should be black
 let bc = [0, 0, 0];
 if (doc._activeColorProfile && doc._activeColorProfile.type === 'cmyk') {
 bc = [1, 1, 1, 1];
 }
 const gstate = doc.ref({
 Type: 'ExtGState',
 CA: 1,
 ca: 1,
 BM: 'Normal',
 SMask: {
 S: 'Luminosity',
 G: group.xobj,
 BC: bc,
 },
 });
 gstate.end();
 doc.page.ext_gstates[name] = gstate;
 doc.addContent('/' + name + ' gs');
 }
 function applyBlendMode(group, blendMode) {
 // map svg blendMode to pdf
 const key = String(blendMode || '').toLowerCase();
Expand DownExpand Up@@ -3297,7 +3319,7 @@ export default function (doc, svg, x, y, options) {
 this.drawChildren(true, false);
 doc.restore();
 docEndGroup(group);
docApplyMask(group);
docApplyAlphaMask(group);
 };
 };

Expand All@@ -3321,11 +3343,16 @@ export default function (doc, svg, x, y, options) {
 if (this.attr('maskContentUnits') === 'objectBoundingBox') {
 doc.transform(bBox[2] - bBox[0], 0, 0, bBox[3] - bBox[1], bBox[0], bBox[1]);
 }
 const maskType = this.attr('mask-type') ?? 'luminance';
 this.clip();
 this.drawChildren(false, true);
 doc.restore();
 docEndGroup(group);
 docApplyMask(group);
 if (maskType === 'alpha') {
 docApplyAlphaMask(group);
 } else {
 docApplyMask(group);
 }

Comment on lines

+3346
 to 
+3355

CopilotAIApr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask-type is read via getAttribute and then compared case-sensitively to 'alpha'. Since mask-type is a CSS keyword/presentation attribute, values should be treated case-insensitively; consider normalizing (e.g., String(...).toLowerCase()) or using the style getter so valid inputs like Alpha/ALPHA work.
Copilot uses AI. Check for mistakes.

 };
 };

Expand Down

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "document",
 "vector"
 ],
 "version": "0.17.56",
 "version": "0.17.58",
 "homepage": "http://pdfkit.org/",
 "author": {
 "name": "Devon Govett",
Expand Down

3 changes: 2 additions & 1 deletion
types/pdfkit.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ shader(fn: () => any): any;
 data: Uint8Array | Buffer;
 channels: number;
 alternate: string | string[];
 type?: 'cmyk' | 'rgb'
 }
}

Expand DownExpand Up@@ -786,7 +787,7 @@ declare namespace PDFKit.Mixins {
 }

 interface PDFColorSpace {
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[]): this;
 iccProfile(label:string, data: Uint8Array | ArrayBuffer, channels: number, alternate: string|string[], type?: 'rgb'|'cmyk'): this;
 }

 interface PDFOutputIntent {
Expand Down
Loading