Volume quality slider

[sankhesh]

Fixes#277 and #248

[netlify]

✅ Deploy Preview for volview ready!

Name	Link
🔨 Latest commit	e5d11d5
🔍 Latest deploy log	https://app.netlify.com/sites/volview/deploys/63eb9ed6df518a0008d25ec8
😎 Deploy Preview	https://deploy-preview-283--volview.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sankhesh]

@aylward PTAL

[aylward]

Looks great! The slider has a noticeable impact - but is there a way to increase realism even further when the maximum quality is selected? On my old system, it is still quite fast on the maximum quality setting - and at that setting we can definitely take more time to do renderings if the quality can be improved.

[netlify]

✅ Deploy Preview for volview-dev ready!

Name	Link
🔨 Latest commit	8b0900f
🔍 Latest deploy log	https://app.netlify.com/sites/volview-dev/deploys/643eb817edcd0100086c7d06
😎 Deploy Preview	https://deploy-preview-283--volview-dev.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[aylward]

Absolutely beautiful! And stable on my phone!

[sankhesh]

@aylward What do you think? -

[aylward]

Thinking about this - I don't think the quality is ever "low"

How about
Good - Better - Ultra - Experimental

One issue also is that there isn't much (enough) space between Ultra and Experimental in the about figure - looks like one label "Ultra Experimental"

Perhaps change Experimental to Beta?

Good - Better - Ultra - Beta

?

[sankhesh]

@aylward Good to merge?

[aylward]

Looks great!!!!

Perhaps the "Don't show again" button could be shown in a different color or have a stronger outline around the button? It is a little hard to tell it is a button on my display.

[floryst]

Here is a stronger and more succinct typing for selectLightingMode:

Suggested change

	const lightingModel = ref<keyof typeof LIGHTING_MODELS>('hybrid');
	const selectLightingMode = (buttonTxt: string) => {
	type LightingModel = keyof typeof LIGHTING_MODELS;
	const lightingModel = ref<LightingModel>('hybrid');
	const selectLightingMode = (buttonTxt: LightingModel) => {

[floryst]

Here is an idea I think would be good to have, but we can do this after this PR is merged: we can have a question mark icon that, when clicked, goes to a page in our documentation that explains what it means when we way "Ultra / Beta is unstable on some systems".

[aylward]

Great idea! s

…

On Tue, Apr 18, 2023 at 3:05 PM Forrest Li ***@***.***> wrote: Here is an idea I think would be good to have, but we can do this after this PR is merged: we can have a question mark icon that, when clicked, goes to a page in our documentation that explains what it means when we way "Ultra / Beta is unstable on some systems". — Reply to this email directly, view it on GitHub <#283 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACEJLYJWQTJOPD75H6X4IDXB3QZLANCNFSM6AAAAAAU3U2DBU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Stephen R. Aylward, Ph.D. Senior Director of Strategic Initiatives Chair of MONAI Advisory Board --- Kitware: *Delivering innovation.*

[sankhesh]

@floryst@aylward How do I bypass the merge queue? I just a see a button Merge when ready and it keeps waiting for the two jobs that don't have anything to do.

[floryst]

I just enabled merge queues in VolView to trial this feature. I think it's not fully set up yet. I'll handle it.