Skip to content

feat: Keyboard shortcut to delete current image and clear scene - #706

Closed
lchauvin wants to merge 0 commit into
Kitware:mainfrom
lchauvin:main
Closed

feat: Keyboard shortcut to delete current image and clear scene#706
lchauvin wants to merge 0 commit into
Kitware:mainfrom
lchauvin:main

Conversation

@lchauvin

Copy link
Copy Markdown
Contributor

Add a keyboard shortcut to delete the current image (ctrl+d), and clear the whole scene (ctrl+w)

@netlify

netlifyBot commented Feb 21, 2025

Copy link
Copy Markdown

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

NameLink
🔨 Latest commit55f993a
🔍 Latest deploy loghttps://app.netlify.com/sites/volview-dev/deploys/67c9eb3a15265f0008bf75d0
😎 Deploy Previewhttps://deploy-preview-706--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHaxPaulHax left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Gracias.

Comment threadsrc/config.ts Outdated
@PaulHax
PaulHax requested a review from florystFebruary 24, 2025 14:32

@florystfloryst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever your final keybinds are, please add them to https://github.com/Kitware/VolView/blob/main/docs/mouse_controls.md.

@lchauvin

Copy link
Copy Markdown
ContributorAuthor

Whatever your final keybinds are, please add them to https://github.com/Kitware/VolView/blob/main/docs/mouse_controls.md.

I changed the shortcut to add modifier, and modified mouse_controls.md

@PaulHax
PaulHax requested a review from florystFebruary 27, 2025 17:59
Comment threadsrc/composables/actions.ts Outdated

const deleteCurrentImage = () => () => {
const datasetStore = useDatasetStore();
datasetStore.remove(datasetStore.primaryImageID!);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for updating datasetStore.remove so that we can pass in null image IDs without checking. That way we can drop the ! operator here.

remove(id: string | null) {
if (!id) return
...
}

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the changes

@PaulHax

Copy link
Copy Markdown
Collaborator

I was trying to squash some of lchauvin's commits and rebase rather than merge on main... but messed up force pushing them back on this PR =/

Guess we just use #713

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lchauvin@PaulHax@floryst