Uh oh!
There was an error while loading. Please reload this page.
Add pybind11 patches - #325
Conversation
dstoup
commented
Feb 16, 2018
A comment about patch branches in general. I prefer 2 commits. One which pushes the original files and a second which applies the patch. That will allow reviewers to see what's actually being changed. |
69277e6 to
e5cadf1CompareKyleFromKitware
commented
Feb 16, 2018
Like this? |
dstoup
commented
Feb 16, 2018
Yes, thank you :) |
dstoup
commented
Feb 16, 2018
Jenkins test this please |
kwcvrobot
commented
Feb 16, 2018
kwcvrobot
commented
Feb 16, 2018
KyleFromKitware
commented
Feb 16, 2018
The builds are failing: Is Jenkins not configured for Python? Does this usually happen? |
dstoup
commented
Feb 16, 2018
FYI, this is more for Dawkins than anyone, but if there are useful changes being made, I would prefer they go into master, not some frankenbranch which will not merge. Are these changes useful for pybind11 in general? |
hughed2
commented
Feb 16, 2018
Kyle, do you want to push that into viame/master or plain master? Jenkins is configured for master, if viame/master needs anything different I wouldn't expect it to work. |
dstoup
commented
Feb 16, 2018
Jenkins is not configured with python and any packages which are added need to assume it can be turned on or off. |
dstoup
commented
Feb 16, 2018
@hughed2 this branch cannot go into master, it was taken from viame/master. |
This adds a set of patches to pybind11 that fixpybind/pybind11#1276 (the changes I've made can be seen in pybind/pybind11#1286)