Uh oh!
There was an error while loading. Please reload this page.
Add pybind11 patches - #326
Closed
KyleFromKitware wants to merge 2 commits into
Closed
Conversation
hughed2
commented
Feb 16, 2018
Contributor
LGTM |
dstoup
commented
Feb 16, 2018
Collaborator
Jenkins test this please |
dstoup
commented
Feb 16, 2018
Collaborator
Looks good to me too. I will merge once the dashboard cycles. |
kwcvrobot
commented
Feb 16, 2018
Collaborator
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=5262451 |
kwcvrobot
commented
Feb 16, 2018
Collaborator
kwcvrobot
commented
Feb 17, 2018
Collaborator
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5262810 |
KyleFromKitware
commented
Feb 19, 2018
ContributorAuthor
Closed because I am going to take a new approach that doesn't involve patching pybind11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a set of patches to pybind11 that fixpybind/pybind11#1276 (the changes I've made can be seen in pybind/pybind11#1286)