Make qt5 the default version by dstoup · Pull Request #485 · Kitware/fletch

dstoup · 2019-01-30T16:54:42Z

Several open source offerings now depend on Qt 5. This PR is initially a test run to see if it builds everywhere before we make a final decision.

mleotta · 2019-01-30T17:07:28Z

Big 👍 on this. Qt5 should be the default in Fletch and Qt4 should be a supported option for packages that haven't upgraded yet. Making Qt5 the default may provide more incentive for those Qt4 users to upgrade. We aren't going to support Qt4 forever.

TeleSculptor (aka MAP-Tk) now requires Qt5. The CI for that project is failing because it uses the packaged nightly dashboard build of Fletch to shorten build times and the default Fletch doesn't have Qt5.

dstoup · 2019-01-30T17:19:18Z

To further add to Matt's comments, there is a component in kwiver now too that relies on Qt 5 and is untested because it is disabled because of Qt 4. I had forgotten about that one earlier.

kwcvrobot · 2019-01-30T18:06:44Z

KWJenkins-FletchLinuxGPUPR-485 experienced errors.

kwcvrobot · 2019-01-30T18:52:27Z

KWJenkins-FletchMacPR-485 experienced errors.

dstoup · 2019-01-30T19:38:58Z

The zlib issue that's failing is something that @chetnieter or @mwoehlke-kitware fixed at one point, I thought for Qt 5. Maybe there was a version bump that missed the patch?

kwcvrobot · 2019-01-30T19:47:25Z

KWJenkins-FletchWindowsPR-485 experienced errors.

Cookt2 · 2019-02-01T20:22:44Z

To elaborate on the various errors this branch has:

Linux:
fails on qtExtensions

/home/kitware/jenkins/workspace/FletchLinuxPR/build/install/bin/moc: error while loading shared libraries: libzlib.so: cannot open shared object file: No such file or directory

We could apply a similar patch Qt got(for finding zlib) to qtExtensions.

Mac:
Qt5 builds fine, qtExtensions fails

Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtOverlayWidgetInterface.h:18: Error: Undefined interface
/Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtDoubleSliderInterface.h:18: Error: Undefined interface
/Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtProgressWidgetInterface.h:18: Error: Undefined interface
/Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtThrobberInterface.h:18: Error: Undefined interface
/Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtExpanderInterface.h:18: Error: Undefined interface
/Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtColorButtonInterface.h:18: Error: Undefined interface
/Users/kitware/Jenkins/workspace/FletchMacPR/build/buildqtExtensions/designer/qtSqueezedLabelInterface.h:18: Error: Undefined interface

Not sure about this one, maybe @mwoehlke-kitware has an idea?

Windows:
Qt5 build fails

C:\Users\kitware.KHQ\workspace\FletchWindowsPR\build\build\src\Qt\qtbase\src\3rdparty\angle\src\libANGLE\renderer\d3d\d3d11\load_functions_table_autogen.cpp : fatal error C1083: Cannot open compiler generated file: '': Invalid argument

I believe this is related to the argument path hitting the windows path limit.

mwoehlke-kitware · 2019-02-05T18:40:11Z

The macOS build error should be fixed by Kitware/qtextensions#19. I would appreciate if some folks that have previously had issues could test.

Cookt2 · 2019-02-05T20:26:02Z

The macOS build error should be fixed by Kitware/qtextensions#19. I would appreciate if some folks that have previously had issues could test.

I'm testing this now! Thanks for this.

mleotta · 2019-02-08T19:36:21Z

@dstoup could you please rebase this on the latest master. @mwoehlke-kitware has merged some changes to Qt extensions which should fix the mac build errors. The other changes we need to address on the Jenkins CI machines (at least for now). Those are:

On Windows make sure the root of the fletch build is short to avoid errors due to long file paths.
On Linux we need to set LD_LIBRARY_PATH=$fletch_ROOT/install/lib before building (at least until we have a better solution).

@Cookt2 can you address those items on the Jenkins CI machines?

Cookt2 · 2019-02-11T14:34:12Z

@dstoup could you please rebase this on the latest master. @mwoehlke-kitware has merged some changes to Qt extensions which should fix the mac build errors. The other changes we need to address on the Jenkins CI machines (at least for now). Those are:
On Windows make sure the root of the fletch build is short to avoid errors due to long file paths.
On Linux we need to set LD_LIBRARY_PATH=$fletch_ROOT/install/lib before building (at least until we have a better solution).
@Cookt2 can you address those items on the Jenkins CI machines?

Done. The changes should be present in the current dashboard run. (if not, the next.)

dstoup · 2019-02-11T14:43:16Z

Thanks, considering there is an existing PR running, I'm hopeful the changes will apply.

…

On Mon, Feb 11, 2019 at 9:34 AM Taylor J. Cook ***@***.***> wrote: @dstoup <https://github.com/dstoup> could you please rebase this on the latest master. @mwoehlke-kitware <https://github.com/mwoehlke-kitware> has merged some changes to Qt extensions which should fix the mac build errors. The other changes we need to address on the Jenkins CI machines (at least for now). Those are: 1. On Windows make sure the root of the fletch build is short to avoid errors due to long file paths. 2. On Linux we need to set LD_LIBRARY_PATH=$fletch_ROOT/install/lib before building (at least until we have a better solution). @Cookt2 <https://github.com/Cookt2> can you address those items on the Jenkins CI machines? Done. The changes should be present in the current dashboard run. (if not, the next.) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#485 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFRAWq3yUEYOoQAvcbrPZ8NyuJk81WPlks5vMX9lgaJpZM4aaoJx> .

-- David Stoup Principal Engineer Kitware, Inc. 1712 Route 9, Suite 300 Clifton Park, NY 12065-3104 518-881-4949 (W) 518-312-3946 (M) 518-371-4573 (F)

kwcvrobot · 2019-02-11T18:15:55Z

KWIVER against Fletch LinuxGPU build succeeded.

kwcvrobot · 2019-02-11T18:15:56Z

KWIVER against Fletch Mac build succeeded.

kwcvrobot · 2019-02-11T18:46:27Z

KWJenkins-FletchWindowsGPUPR-485 experienced errors.

Cookt2 · 2019-02-11T19:55:52Z

Jenkins test this please

kwcvrobot · 2019-02-11T20:36:36Z

KWJenkins-FletchWindowsGPUPR-485 experienced errors.

kwcvrobot · 2019-02-11T22:52:03Z

KWIVER against Fletch Linux build succeeded.

kwcvrobot · 2019-02-11T22:52:06Z

KWIVER against Fletch LinuxGPU build succeeded.

kwcvrobot · 2019-02-11T22:52:07Z

KWIVER against Fletch Mac build succeeded.

kwcvrobot · 2019-02-13T17:49:18Z

KWJenkins-FletchWindowsPR-485 experienced errors.

kwcvrobot · 2019-03-20T00:09:45Z

KWIVER against Fletch Linux build succeeded.

kwcvrobot · 2019-03-20T00:27:00Z

KWIVER against Fletch LinuxGPU build succeeded.

kwcvrobot · 2019-03-20T00:38:35Z

KWIVER against Fletch Mac build succeeded.

kwcvrobot · 2019-03-20T02:19:59Z

KwiverCheckWindowsPR experienced errors.

dstoup · 2019-03-20T11:45:55Z

Finally Qt5 looks good. There are kwiver issues, but I think they are still related to the recent image changes. I will have to bisect there again today and see why, but this branch is ready to go when consensus says we should.

mleotta · 2019-03-20T12:18:43Z

You have my vote

dstoup · 2019-03-20T12:50:24Z

You have my vote

Thanks Matt, you were the number 1 person I was going to ask. I think everyone else is onboard.

mwoehlke-kitware · 2019-03-20T14:21:22Z

You have my vote

Likewise 👍

Cookt2 · 2019-03-20T14:46:52Z

+1!

mwoehlke-kitware mentioned this pull request Feb 6, 2019
Update qtExtensions #492
Merged

Cookt2 mentioned this pull request Feb 25, 2019
Upgrade OpenCV 3.4.0 to 3.4.1 #504
Open

dstoup added 2 commits March 19, 2019 18:29

Remove the python requirement and add no-qml-debug to the minimal build
a1b8324

Make Qt5 the default version
f843d0a

dstoup force-pushed the qt5-default branch from 65fdbab to f843d0aCompare March 19, 2019 22:30

dstoup merged commit 7916821 into Kitware:masterMar 20, 2019

dstoup deleted the qt5-default branch March 21, 2019 20:32

Uh oh!

Conversation

dstoup commented Jan 30, 2019

Uh oh!

mleotta commented Jan 30, 2019

Uh oh!

dstoup commented Jan 30, 2019

Uh oh!

kwcvrobot commented Jan 30, 2019

Uh oh!

kwcvrobot commented Jan 30, 2019

Uh oh!

dstoup commented Jan 30, 2019

Uh oh!

kwcvrobot commented Jan 30, 2019

Uh oh!

Cookt2 commented Feb 1, 2019

Uh oh!

mwoehlke-kitware commented Feb 5, 2019

Uh oh!

Cookt2 commented Feb 5, 2019

Uh oh!

mleotta commented Feb 8, 2019

Uh oh!

Cookt2 commented Feb 11, 2019

Uh oh!

dstoup commented Feb 11, 2019 via email

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

Cookt2 commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 11, 2019

Uh oh!

kwcvrobot commented Feb 13, 2019

Uh oh!

kwcvrobot commented Mar 20, 2019

Uh oh!

kwcvrobot commented Mar 20, 2019

Uh oh!

kwcvrobot commented Mar 20, 2019

Uh oh!

kwcvrobot commented Mar 20, 2019

Uh oh!

dstoup commented Mar 20, 2019

Uh oh!

mleotta commented Mar 20, 2019

Uh oh!

dstoup commented Mar 20, 2019

Uh oh!

mwoehlke-kitware commented Mar 20, 2019

Uh oh!

Cookt2 commented Mar 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants