Skip to content

Update gtest version - #626

Open
dstoup wants to merge 5 commits into
Kitware:masterfrom
dstoup:update-gtest-version
Open

Update gtest version#626
dstoup wants to merge 5 commits into
Kitware:masterfrom
dstoup:update-gtest-version

Conversation

@dstoup

@dstoupdstoup commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@kwcvrobot

kwcvrobot commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator

KWJenkins-FletchLinuxPR-626 experienced errors.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Centos build succeeded.

1 similar comment
@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Centos build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch LinuxGPU build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Linux build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Mac build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Centos build succeeded.

mwoehlke-kitware
mwoehlke-kitware reviewed Oct 28, 2020
View reviewed changes

@mwoehlke-kitwaremwoehlke-kitware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay in principle, not approved because of question re: patching (but not -1'd either).

Comment threadPatches/GTest/Patch.cmake Outdated
Comment threadDoc/release-notes/master.txt Outdated
@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch LinuxGPU build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Linux build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Mac build succeeded.

@dstoup
Merge branch 'master' into update-gtest-version
099ccd0
* master:
Update release notes
Remove support for OpenCV v2
Patch Caffe Dependencies to prevent Caffe overwriting the HDF5 libs from find_package
Create Caffe patch that overrides incorrect hdf5 lib search
Update release notes
Add VTK version 9.0.1
Use the tar.gz files from the download site.
Remove VTK 6
Add HDF5 update, version 1.12.0
@dstoup
Remove GTest patches. One is merged upstream, the other might not be …
3a7c355
…required
@dstoup
dstoupforce-pushed the update-gtest-version branch from bd7f552 to 3a7c355CompareOctober 28, 2020 18:10
@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Centos build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch LinuxGPU build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Linux build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Fletch KWIVER against Fletch Mac build succeeded.

@kwcvrobot

kwcvrobot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

KwiverCheckWindowsPR experienced errors.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwoehlke-kitwaremwoehlke-kitwaremwoehlke-kitware left review comments
@linus-sherrilllinus-sherrillAwaiting requested review from linus-sherrill

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dstoup@kwcvrobot@mwoehlke-kitware