Reject duplicate Web App data keys - #4
Open
KnightNiwrem wants to merge 2 commits into
Open
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
KnightNiwrem
marked this pull request as ready for review
August 22, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLSearchParamskeys before token-based HMAC validationhash, andsignaturein regression testsTesting
Summary by cubic
Reject duplicate Web App data keys before HMAC or Ed25519 verification to prevent ambiguous parsing and signature bypass via repeated parameters. Previously duplicates were accepted with the last value used; now any duplicate key causes validation to return false.
query_id,chat_type,hash,signature).hasDuplicateKeyshelper for simpler, centralized detection; public API and return values are unchanged.Migration
hash,signature, or any other duplicate parameters.Written for commit daf0a42. Summary will update on new commits.