Uh oh!
There was an error while loading. Please reload this page.
Added environments - #1103
Merged
Merged
Conversation
ContributorAuthor
Nyholm
approved these changes
Mar 9, 2023
Nyholm
left a comment
Collaborator
There was a problem hiding this comment.
Lovely. Thank you for adding docs and tests.
ContributorAuthor
Hi @Nyholm Will check why test are failing Also I will do few more PRs ( For ENV varaibles and Secrets) Also for ORG, Repo varaibles (currently is only secretes) |
Nyholm
commented
Mar 9, 2023
Collaborator
It seams like the tests are still failing |
Tested locally all passed
SergkeiM
commented
Mar 9, 2023
ContributorAuthor
Hi @Nyholm Tests are fixed now, except |
acrobat
requested changes
Mar 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
acrobat
commented
Mar 9, 2023
Collaborator
The failing BC checker workflow can be ignored as it is not related to this change. One smal change/comment from my side, otherwise go to go! |
This api doesn't require a custom beta accept header, so the trait usage can be removed
Closed
acrobat
approved these changes
Mar 9, 2023
Nyholm
commented
Mar 9, 2023
Collaborator
Thank you |
acrobat
commented
Mar 9, 2023
Collaborator
Thanks @FROXZ! And congrats on your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for environments #1102