Skip to content

Added environment variables & secrets - #1104

Merged
acrobat merged 5 commits into
KnpLabs:masterfrom
SergkeiM:feature/env-vars
Mar 10, 2023
Merged

Added environment variables & secrets#1104
acrobat merged 5 commits into
KnpLabs:masterfrom
SergkeiM:feature/env-vars

Conversation

@SergkeiM

@SergkeiMSergkeiM commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Added environment:

Secrets
Variables

@SergkeiM

SergkeiM commented Mar 9, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @acrobat@Nyholm when have time please review 👍

acrobat
acrobat requested changes Mar 9, 2023
View reviewed changes
Comment threadlib/Github/Api/Environment/Secrets.php Outdated
Comment threadlib/Github/Api/Environment/Variables.php Outdated
@SergkeiM
Removed validation of parameters
cbf08fc
removed MissingArgumentException
@SergkeiM
SergkeiM requested a review from acrobatMarch 10, 2023 06:57
@acrobat
acrobat merged commit acc0453 into KnpLabs:masterMar 10, 2023
@acrobat

acrobat commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

Thank you @FROXZ

@SergkeiM
SergkeiM deleted the feature/env-vars branch March 10, 2023 11:17
@SergkeiM

SergkeiM commented Mar 10, 2023

Copy link
Copy Markdown
ContributorAuthor

@acrobat Thank you.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acrobatacrobatacrobat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergkeiM@acrobat