Uh oh!
There was an error while loading. Please reload this page.
Add workflow dispatch and allow workflow names. - #969
Conversation
bummzack
commented
Mar 3, 2021
I'm looking for this functionality as well. Any chance to get this merged? |
bummzack
commented
Mar 3, 2021
I've tested using this PR, but there's an issue when dispatching without the optional
I think inputs should be omitted if there's no input to be specified… this works: publicfunctiondispatches(string$username, string$repository, string$workflow, string$ref, array$inputs = null)
{
$parameters = array_filter(['ref' => $ref, 'inputs' => $inputs]);
return$this->post('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/actions/workflows/'.rawurlencode($workflow).'/dispatches', $parameters);
} |
acrobat
left a comment
There was a problem hiding this comment.
Thanks for the PR! 1 general remark/question, can you remove the @link url changes and move them to a seperate PR as they are not related to this specific feature. This will allow the git history to give a better insight in why a certain change was done. Thanks!
Apart from 2 comments on the dispatch methods, this pr looks good! 👌
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fodinabor
commented
Mar 6, 2021
should be non-BC breaking now (even though Roave still doesn't like it), will wait for the URL update until this is merged |
acrobat
commented
Mar 6, 2021
Thanks @fodinabor! And congrats on your first contribution! 🎉 |
Adds the workflow dispatch proposed in #939.
This is different from the repository dispatch, as here it is clear what arguments to use, so that this is much more convenient to use.
Also update docs link.