Skip to content

add java async http client - #163

Merged
reynolek merged 1 commit into
Kong:masterfrom
windard:add_java_asynchttp
May 27, 2020
Merged

add java async http client#163
reynolek merged 1 commit into
Kong:masterfrom
windard:add_java_asynchttp

Conversation

@windard

@windardwindard commented May 8, 2020

Copy link
Copy Markdown
Contributor

Add Java AsyncHttpClient

@windard
windardforce-pushed the add_java_asynchttp branch from 3614214 to 0fe2422CompareMay 8, 2020 05:09
@windard

windard commented May 8, 2020

Copy link
Copy Markdown
ContributorAuthor

I hope somebody will see it , and approve&merge it as soon as possible.

nijikokun
nijikokun reviewed May 22, 2020
View reviewed changes
Comment threadsrc/targets/java/asynchttp.js Outdated

var code = new CodeBuilder(opts.indent)

// var methods = [ 'GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD', 'OPTIONS', 'TRACE', 'CONNECT' ]

@nijikokunnijikokunMay 22, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover code?

@windardwindardMay 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete leftover code

@nijikokun

nijikokun commented May 22, 2020

Copy link
Copy Markdown

👋 Thank you for submitting this! Sorry it's taken a while to get some 👀 on it. I've left one comment, and others should start trickling in shortly ❤️

@windard
windardforce-pushed the add_java_asynchttp branch from 0fe2422 to 6d3f7eeCompareMay 27, 2020 02:11
@windard
add java async http client
fa57cba
Change-Id: Ic28431ae73b499e929545f95d746b1606fd639f3
fix double quote
Change-Id: I7a8d4aa4cfd96159886436b89fc73096c9e740c5
fixture tests
Change-Id: I355747450a1b47dc356ed97ba3da3c4b48ea6adc
fix travis ci
Change-Id: I88295b5adf157420052793c94b74dbdcb1abdaf3
small update
Change-Id: Iabdddda1142500d14da1ab9157396d9871118130
close async http clinet
Change-Id: Ie61baf7f5e19ed06e3799799d1604e6bf32a54fd
delete leftover code
Change-Id: I67c4b6e929903bd6a6e7e79cbbb596d2f33b0696
@windard
windardforce-pushed the add_java_asynchttp branch from 6d3f7ee to fa57cbaCompareMay 27, 2020 02:12
@reynolek
reynolek merged commit cc8e368 into Kong:masterMay 27, 2020
This was referenced Sep 13, 2021
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@nijikokunnijikokunnijikokun left review comments
@reynolekreynolekreynolek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@windard@nijikokun@reynolek