Uh oh!
There was an error while loading. Please reload this page.
fix: handling of multipart/form-data requests - #173
Conversation
reynolek
commented
Aug 16, 2020
@develohpanda Mind looking at this PR? |
reynolek
commented
Aug 17, 2020
@erunion I believe after merging the code that changed var -> const, this created a handful of merge conflicts. |
erunion
commented
Aug 17, 2020
@reynolek Conflicts resolved. |
develohpanda
left a comment
There was a problem hiding this comment.
Awesome work, thanks for putting your time into this PR! I am largely unfamiliar with this topic, and your code comments were very useful. 💯
I have just a couple of notes and questions, however nothing major nor blocking!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
erunion
commented
Aug 20, 2020
@develohpanda Thanks for the review, and I've addressed your feedback. |
develohpanda
left a comment
There was a problem hiding this comment.
Nicely done, thanks for your explanations as well!
johanbook
commented
Sep 25, 2020
When will this fix be released @develohpanda? |
develohpanda
commented
Sep 25, 2020
@johanbook I have added a card to our board to publish a new version, we'll get to it hopefully this week or next week. |
reynolek
commented
Sep 25, 2020
Released in 1.23.0 |
multipart/form-datacontent types in order to accommodate library utilization within the browser where the nativeFormDatacomponent is used.form-dataandFormDatathat was causing the library to fail in the browser were two issues:FormData.appendhas three arguments, and the third should only be present if the second is aBloborUSVString. It is never an object, asform-datarequires it to be.FormData.pipe()isn't a function.requesttarget that was causingfs.createReadStreampointers to be stringified and unusable.param.fileNameif it's present, even ifparam.valuealso is:requestrequesttarget to prefer single quotes inrequirestatements andrequest.cookiecalls. Since the rest of the snippet already preferred this, this change makes the whole snippet look a touch more cohesive and consistent.Resolves#111