Uh oh!
There was an error while loading. Please reload this page.
fix: don't convert header names to lowercase - #178
Conversation
bfab905 to
b5e1039CompareThere was a problem hiding this comment.
Thanks for finishing this off!
Do you have any thoughts about whether handling headers with HTTP/1.1 (case-insensitive) vs HTTP/2 (case-sensitive) is the responsibility of this library, or responsibility of the consumer? (cc: @darrenjennings)
I am impartial, but since we have access to the version on the HAR object, we might as well follow the RFC.
Uh oh!
There was an error while loading. Please reload this page.
b5e1039 to
4076e96Compare
develohpanda
left a comment
There was a problem hiding this comment.
Looks good now, nice to see an additional unit test! 👍
Just a minor comment on the use of regex
Uh oh!
There was an error while loading. Please reload this page.
4076e96 to
958b1e0Comparereynolek
commented
Sep 25, 2020
released in 1.23.0 |
erunion
commented
Oct 15, 2020
This change has unfortunately introduced some header duping in some cases of commonly used headers like I'm working on a PR right now though. |
I've completed @darrenjennings branch to remove the
.toLowerCasefor header names.Closes#74