Use proper quoting in HTTPie shell commands

[jkbrzt]

This looks like an interesting project 👍 I've noticed a problem with quoting of the shell commands and this pull request fixes that for HTTPie:

Before, the resultant shell command was completely unquoted. This change introduces proper quoting of values and the URL - when necessary.

It uses single quotes which provide "strong quoting" (only nested single quote characters need to be taken care of) and also make the output more readable as double quotes, ubiquitous in JSON, don't require escaping.

Before:

echo"{\"foo\": \"bar\"}"|\ 
http POST http://mockbin.com/request?foo=bar&foo=baz \
accept:application/json \
content-type:application/json \
cookie:foo=bar; bar=baz

After:

echo'{"foo": "bar"}'|\ # Improved readability
http POST 'http://mockbin.com/request?foo=bar&foo=baz'\ # Quoted "&"
accept:application/json \ # No quoting necessary
content-type:application/json \ # No quoting necessary
cookie:'foo=bar; bar=baz'# Quoted ";"

---

The cURL command (and possible also Wget) most likely suffer from improper quoting as well. It's not completely missing, as was the case of HTTPie, but it uses double quotes so literals like "foo bar $HOME baz" might get expanded by the shell. I think the same quoting mechanism should be used there as well.

[thibaultcha]

👍

[ahmadnassri]

nice 👍 thanks @jakubroztocil I will integrate this with curl and wget as well.