Skip to content

More fixes - #6

Merged
julienblin-kothar merged 16 commits into
mainfrom
more-fixes
Aug 13, 2025
Merged

More fixes#6
julienblin-kothar merged 16 commits into
mainfrom
more-fixes

Conversation

@julienblin-kothar

Copy link
Copy Markdown
Collaborator

This PR is for increasing the capabilities offered with REST VOL.

The main thing is really to fix the variable-string read to right-trim all the \0 characters.

The rest is a series of fixes and an overall of the unit tests so that:

  • in CI, without REST VOL, everything should pass
  • inside the devcontainer, with REST VOL, everything should pass as well - it is just that some tests are OK with being bypassed because REST VOL do not support it correctly.

@julienblin-kothar
julienblin-kotharforce-pushed the more-fixes branch 4 times, most recently from 3cdb7fc to 8060093CompareAugust 12, 2025 19:20

@vincentmrvincentmr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, much cleaner now. I left a couple nitpick suggestions to clean up the code. I think there is only one place where CHECKs were removed and wondering why. Happy to approve afterwards.

Comment threadinclude/highfive/bits/H5Slice_traits_misc.hpp
Comment threadinclude/highfive/bits/H5Slice_traits_misc.hpp Outdated
Comment threadinclude/highfive/bits/H5Slice_traits_misc.hpp Outdated
Comment threadtests/unit/test_all_types.cpp
Comment threadtests/unit/test_empty_arrays.cpp
Comment threadtests/unit/test_string.cpp
Comment threadtests/unit/test_string.cpp
Comment threadtests/unit/tests_high_five_base.cpp
@julienblin-kothar
julienblin-kothar merged commit 4ac9609 into mainAug 13, 2025
23 checks passed
@julienblin-kothar
julienblin-kothar deleted the more-fixes branch August 13, 2025 18:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@julienblin-kothar@vincentmr