Uh oh!
There was an error while loading. Please reload this page.
More fixes - #6
Conversation
3cdb7fc to
8060093Compare8060093 to
a0ae1e2Compare
vincentmr
left a comment
There was a problem hiding this comment.
Love this, much cleaner now. I left a couple nitpick suggestions to clean up the code. I think there is only one place where CHECKs were removed and wondering why. Happy to approve afterwards.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR is for increasing the capabilities offered with REST VOL.
The main thing is really to fix the variable-string read to right-trim all the
\0characters.The rest is a series of fixes and an overall of the unit tests so that: