Uh oh!
There was an error while loading. Please reload this page.
Fb merge discvr develop - #3
Closed
bbimber wants to merge 2 commits into
Closed
Conversation
bbimber
commented
Nov 22, 2019
CollaboratorAuthor
@labkey-jeckels , @labkey-tchad what do you guys want as the procedure to approve these PRs? these should be just my lab's modules. |
labkey-tchad
self-requested a review
November 22, 2019 18:00
labkey-tchad
requested changes
Nov 22, 2019
labkey-tchad
left a comment
Member
There was a problem hiding this comment.
Since you are going to be branching discvr19.3, these changes should go into 19.3-SNAPSHOT. I rebased your changes onto 19.3-SNAPSHOT: 19.3_fb_merge_discvr. Please open a new pull request from that branch (GitHub associates the merge with whoever opens the pull request).
bbimber added a commit
that referenced
this pull request
Feb 8, 2020
* Support multiple types of scatter/gather * Reconcile AnnotationStep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.