Skip to content

Remove SQL Server upgrade scripts and code - #431

Merged
labkey-jeckels merged 2 commits into
developfrom
fb_removeSqlServer2
Aug 24, 2026
Merged

Remove SQL Server upgrade scripts and code#431
labkey-jeckels merged 2 commits into
developfrom
fb_removeSqlServer2

Conversation

@labkey-jeckels

Copy link
Copy Markdown

Rationale

We no longer support SQLServer as a primary DB

Changes

  • Remove schema upgrade scripts
  • Remove SQLServer conditional code
  • Remove SupportedDatabases in module.properties
  • Remove uses of PostgresOnlyTest

@labkey-jeckels
labkey-jeckels requested review from a team and bbimberAugust 23, 2026 16:58
@labkey-jeckelslabkey-jeckels self-assigned this Aug 23, 2026
@labkey-jeckels

Copy link
Copy Markdown
Author

@bbimber this repo was very straightforward.

bbimber
bbimber previously requested changes Aug 24, 2026

@bbimberbbimber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's a change from existing behavior, I'd like to restore natural sorting on these columns for PG. I can check in a change unless you are able to.

@labkey-jeckels

Copy link
Copy Markdown
Author

Even though it's a change from existing behavior, I'd like to restore natural sorting on these columns for PG. I can check in a change unless you are able to.

Sounds good. Go for it at your convenience. I've intentionally done these PRs such that they can be merged independently and then we'll do a followup small cleanup to actually delete things like the PostgresOnlyTest marker interface.

@bbimber
bbimber dismissed their stale reviewAugust 24, 2026 15:19

change added

@labkey-jeckels
labkey-jeckels merged commit 783f3f0 into developAug 24, 2026
7 of 8 checks passed
@labkey-jeckels
labkey-jeckels deleted the fb_removeSqlServer2 branch August 24, 2026 16:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-jeckels@bbimber