Skip to content

Rename SaveRowsResponse to RowsResponse#252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 1 commit into from
Jul 18, 2025
Merged

Rename SaveRowsResponse to RowsResponse #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions LDK/test/src/org/labkey/test/tests/external/labModules/LabModulesTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
import org.labkey.remoteapi.collections.CaseInsensitiveHashMap;
import org.labkey.remoteapi.query.Filter;
import org.labkey.remoteapi.query.InsertRowsCommand;
import org.labkey.remoteapi.query.SaveRowsResponse;
import org.labkey.remoteapi.query.RowsResponse;
import org.labkey.remoteapi.query.SelectRowsCommand;
import org.labkey.remoteapi.query.SelectRowsResponse;
import org.labkey.remoteapi.query.Sort;
Expand DownExpand Up@@ -530,7 +530,7 @@ private void insertSubjects() throws Exception
insertCmd.addRow(rowMap);
}

SaveRowsResponse saveResp = insertCmd.execute(cn, getProjectName());
RowsResponse saveResp = insertCmd.execute(cn, getProjectName());
assertEquals("Incorrect number of rows created", SUBJECTS.length, saveResp.getRowsAffected().intValue());
}

Expand All@@ -553,7 +553,7 @@ private void insertProjectEnrollment() throws Exception
insertCmd.addRow(rowMap);
}

SaveRowsResponse saveResp = insertCmd.execute(cn, getProjectName());
RowsResponse saveResp = insertCmd.execute(cn, getProjectName());
assertEquals("Incorrect number of rows created", PROJECT_ENROLLMENT.length, saveResp.getRowsAffected().intValue());

//test expectations
Expand DownExpand Up@@ -598,7 +598,7 @@ private void insertSamples() throws Exception
insertCmd.addRow(rowMap);
}

SaveRowsResponse saveResp = insertCmd.execute(cn, getProjectName());
RowsResponse saveResp = insertCmd.execute(cn, getProjectName());
assertEquals("Incorrect number of rows created", SAMPLE_DATA.length, saveResp.getRowsAffected().intValue());
}

Expand All@@ -618,7 +618,7 @@ private void insertMajorEvents() throws Exception
insertCmd.addRow(rowMap);
}

SaveRowsResponse saveResp = insertCmd.execute(cn, getProjectName());
RowsResponse saveResp = insertCmd.execute(cn, getProjectName());
assertEquals("Incorrect number of rows created", MAJOR_EVENTS.length, saveResp.getRowsAffected().intValue());
}

Expand DownExpand Up@@ -1739,7 +1739,7 @@ private void peptideTableTest() throws Exception
rowMap.put("_selfAssignedId_", "true");
insertCmd.addRow(rowMap);

SaveRowsResponse saveResp = insertCmd.execute(cn, getProjectName());
RowsResponse saveResp = insertCmd.execute(cn, getProjectName());
throw new Exception("The saveRows call above should have thrown an exception");
}
catch (CommandException e)
Expand Down