Skip to content

Remove support for useEmbeddedTomcat, tomcat-lib, and log4j2.xml - #216

Merged
labkey-adam merged 12 commits into
developfrom
fb_useEmbedded
Sep 6, 2024
Merged

Remove support for useEmbeddedTomcat, tomcat-lib, and log4j2.xml#216
labkey-adam merged 12 commits into
developfrom
fb_useEmbedded

Conversation

@labkey-adam

Copy link
Copy Markdown
Contributor

Rationale

No need to handle standalone builds

@labkey-susanhlabkey-susanh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some methods and/or properties that

Comment threadsrc/main/groovy/org/labkey/gradle/plugin/ServerDeploy.groovy
Comment threadsrc/main/groovy/org/labkey/gradle/plugin/ServerDeploy.groovy
Comment threadsrc/main/groovy/org/labkey/gradle/task/RunUiTest.groovy Outdated
Comment threadsrc/main/groovy/org/labkey/gradle/plugin/TeamCity.groovy
Comment threadsrc/main/groovy/org/labkey/gradle/plugin/ServerDeploy.groovy

@labkey-tchadlabkey-tchad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably get rid of the entire distributionResources directory and any tasks that publish it. The distributionResources/embedded is just an incomplete duplicate of server/configs/webapps/embedded. The files here are only used if the corresponding files from the server repo are missing -- which should never happen. Everything else in distributionResources is for standalone tomcat.

Comment threadsrc/main/groovy/org/labkey/gradle/task/DeployApp.groovy
Comment threadsrc/main/groovy/org/labkey/gradle/task/RunUiTest.groovy Outdated

@labkey-susanhlabkey-susanh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might still be able to clean up that TomcatExtension, but I'm going to leave that for Trey to answer (and we can do it later if we find it's not used).

Comment threadsrc/main/groovy/org/labkey/gradle/plugin/ServerDeploy.groovy
@labkey-adam
labkey-adam merged commit 8dfab4d into developSep 6, 2024
@labkey-adam
labkey-adam deleted the fb_useEmbedded branch September 6, 2024 00:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-adam@labkey-tchad@labkey-susanh