Uh oh!
There was an error while loading. Please reload this page.
Remove support for useEmbeddedTomcat, tomcat-lib, and log4j2.xml - #216
Conversation
labkey-susanh
left a comment
There was a problem hiding this comment.
I think there are some methods and/or properties that
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
labkey-tchad
left a comment
There was a problem hiding this comment.
We can probably get rid of the entire distributionResources directory and any tasks that publish it. The distributionResources/embedded is just an incomplete duplicate of server/configs/webapps/embedded. The files here are only used if the corresponding files from the server repo are missing -- which should never happen. Everything else in distributionResources is for standalone tomcat.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Trey Chadick <tchad@labkey.com>
labkey-susanh
left a comment
There was a problem hiding this comment.
Might still be able to clean up that TomcatExtension, but I'm going to leave that for Trey to answer (and we can do it later if we find it's not used).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Rationale
No need to handle standalone builds