Uh oh!
There was an error while loading. Please reload this page.
Don't modify signature of 'Connection' constructor. - #25
Conversation
labkey-jeckels
left a comment
There was a problem hiding this comment.
Is there a reason to reintroduce this exception instead of updating the JDBC side? As long as a change needs to be made, why not make them consistent instead?
labkey-tchad
commented
Feb 11, 2022
Just trying to follow semver rules. Keep it backward compatible for 1.5.0 then do a wider fixup round for 2.0 at some point. |
labkey-jeckels
commented
Feb 11, 2022
Makes sense. What about calling it 2.0.0? I know it's not a grand refactor or anything, but semver doesn't care. |
| } | ||
| public static void main(String[] args) throws IOException | ||
| public static void main(String[] args) throws IOException, URISyntaxException |
There was a problem hiding this comment.
Is this edit needed now?
labkey-tchad
commented
Apr 18, 2022
Obviated by #26 |
Rationale
A previous update changed the signature of one of the 'Connection' constructors. This broke compatibility with some usages that were catching the
URISyntaxExceptionit claimed to throw.This makes the constructors inconsistent but fixing those up is a job for another day.
Related Pull Requests
Changes