Uh oh!
There was an error while loading. Please reload this page.
[bot] Fast-forward for 26.3.18 - #750
Merged
Merged
Conversation
…equired state (#721) ## Rationale A death or departure record could be finalized while other data for the animal was still in the Review Required QC state, leaving unreviewed records behind for an animal no longer at the center. Completing a death or departure now fails validation until that data is reviewed, except for records on the completing record's own task, which move to Completed in the same save. ## Related Pull Requests None. ## Changes - Added the `study.studyDataReviewRequired` module query (`study.StudyData` joined to `core.QCState`) listing records in Review Required state. - Added `NIRC_EHRTriggerHelper.getReviewRequiredDatasets`, returning the dataset labels still in Review Required for an animal, excluding records on the given taskid. - The `deaths.js` and `departure.js` triggers now block saving a record as Completed while review-required data exists, naming the offending dataset(s) in the error. - Added `NIRC_EHRTest.testDeathAndDepartureBlockedByReviewRequiredData` covering the blocked path and the own-task exclusion for both datasets via validate-only API saves.
labkey-klum
approved these changes
Aug 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.3_ff_bot_26.3.18