Skip to content

Vomit observation entry fix - #1080

Merged
kollil merged 10 commits into
release23.11-SNAPSHOTfrom
23.11_fb_VomitObs
Aug 5, 2024
Merged

Vomit observation entry fix#1080
kollil merged 10 commits into
release23.11-SNAPSHOTfrom
23.11_fb_VomitObs

Conversation

@kollil

Copy link
Copy Markdown
Collaborator

Added vomit entry as an observation

@github-actions

Copy link
Copy Markdown

ERROR: A pull request from 23.11_fb_VomitObs is expected to target release23.11-SNAPSHOT, not develop

@kollil
kollil requested a review from OhsudevJuly 24, 2024 18:06
@kollil
kollil changed the base branch from develop to release23.11-SNAPSHOTJuly 29, 2024 21:50
@kollil

kollil commented Jul 31, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@labkey-martyp
The automated tests are failing on this update. It's saying cannot find the "vomit" query in ehr_lookups.
I have added all the necessary data that's needed to populate the vomit data as an observation.
Could you please check and suggest if I am missing anything?

Thanks
Lakshmi

alopecia_score Alopecia Type value
alopecia_regrowth Alopecia Regrowth value
mens_score Mens Score value
vomit Vomit value

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace between these values needs to be tabs. You have spaces here.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-martyp, I have made that correction and automated tests still failed with the same errors.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kollil Marty's requested changes were not implemented although it looks like you found another place where tabs should be used. Marty was talking abou thte lookup_sets.tsv file. To demonstrate the issue, download the tsv and open it in excel. https://github.com/LabKey/onprcEHRModules/blob/23.11_fb_VomitObs/onprc_ehr/resources/data/lookup_sets.tsv

Please notice that this comment thread start by Marty is pointing at the lookup_sets.tsv file, not the vomit.tsv file.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jryurkanin, Thanks for giving me the tip of downloading into an excel. I did add the tabs in the code first time Marty pointed out, but, somehow the tabs were not getting inserted in the code. I copied the entire tsv file into wordpad, added tabs and then pasted back into the code. Finally it worked.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that worked for you. I actually recommend building the TSV files in excel, then you can copy and paste the table from excel straight into the github website code editor. When you do that, it retains the correct tabular format from excel.

@kollil
kollil merged commit ecc5ea6 into release23.11-SNAPSHOTAug 5, 2024
@kollil
kollil deleted the 23.11_fb_VomitObs branch August 5, 2024 17:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kollil@labkey-martyp@Ohsudev@jryurkanin