Skip to content

PMIC service req form flow changes. - #157

Merged
kollil merged 10 commits into
release20.11-SNAPSHOTfrom
20.11_fb_Changes_PMIC
May 17, 2021
Merged

PMIC service req form flow changes.#157
kollil merged 10 commits into
release20.11-SNAPSHOTfrom
20.11_fb_Changes_PMIC

Conversation

@kollil

Copy link
Copy Markdown
Collaborator

Rationale

This update contains the PMIC flow after the taskid is created. A new label is created for PMIC task to "More actions" list.

@labkey-jeckelslabkey-jeckels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine if you want to proceed as-is, but I know you're interested in splitting out the query so that you can avoid having two Create Task menu items

@kollil
kollil merged commit b0260e8 into release20.11-SNAPSHOTMay 17, 2021
@kollil
kollil deleted the 20.11_fb_Changes_PMIC branch May 17, 2021 23:55
@kollil

Copy link
Copy Markdown
CollaboratorAuthor

Josh, After I merged the changes, I see an error on team city for the build #224. That update is also included in the final merge.
Does that effect my merge?

@labkey-ankurj

Copy link
Copy Markdown
Contributor

Hi @kollil , Josh is out this week, think that error is not related to any change. After getting merged, there is a new build running on the default branch https://teamcity.labkey.org/buildConfiguration/LabKey_2011Release_External_Onprc_OnprcInstaller?branch=%3Cdefault%3E&buildTypeTab=overview&mode=builds

@kollil

Copy link
Copy Markdown
CollaboratorAuthor

Thank you Ankur for checking!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kollil@labkey-ankurj@labkey-jeckels