Uh oh!
There was an error while loading. Please reload this page.
Issue 41014: fix flagging of flow FCSAnalysis wells - #1434
Merged
Conversation
- add Identifiable.getExpObject() for attaching flag comment - also fix some unencoded strings
labkey-jeckels
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Flagging flow wells broke after flow objects were refactored to implement Identifiable.
The SetFlagAction uses ExperimentService.findObjectFromLSID() to resolve Identifiable objects using LsidManager.getObject(lsid) and expects the result to implement ExpObject. After refactoring flow objects to implement Identifiable, FlowFCSAnalysis objects are now found before the underlying ExpData object. The fix is to teach Identifiable how to get a corresponding ExpObject which the SetFlag action can use to set the comment.
Related Pull Requests
Changes