Uh oh!
There was an error while loading. Please reload this page.
Change SimpleTableDomainKind to use getValueSql - #1462
Merged
Conversation
labkey-matthewb
requested changes
Aug 5, 2020
labkey-matthewb
left a comment
Contributor
There was a problem hiding this comment.
It's not obvious, but It is a little suspect to mix and match the SchemaTableInfo (variable table) and a columns from the SimpleTable (variable table). Makes more sense to stick with only objects from table or only objects from schemaTable.
Also avoid using String + SQLFragment. That may not do what you want.
sql.append("SELECT o.ObjectId FROM ").append(table.getFromSql("me")).append(...).append(objectUriColumn.getValueSql("me").append(...)
labkey-matthewb
approved these changes
Aug 5, 2020
cnathe added a commit
that referenced
this pull request
Aug 25, 2026
…r run container (#7979) ## Rationale LabKey/internal-issues#1462 ## Related Pull Requests - #7979 - LabKey/premiumModules#726 ## Changes - QCStateAction to check for AssayReadPermission for run container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Looks like SimpleTableDomainKind needs to use getValueSql instead of getSelectName after the related PR.
https://teamcity.labkey.org/repository/download/LabKey_Trunk_LabkeyPremiumTrunk_GitModules_SnprcEhrSqlserver/1080510:id/tomcatLogs.tar.gz!/labkey-errors.log
Related Pull Requests
#1458
Changes
Update SimpleTableDomainKind.sqlObjectIdsInDomain to use getValueSql