You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I agree the path and declared package should match, but I'd prefer to use the logging subpackage or get rid of it completely. I guess my attempt at moving it in the original FB didn't go well.
I agree the path and declared package should match, but I'd prefer to use the logging subpackage or get rid of it completely. I guess my attempt at moving it in the original FB didn't go well.
Since log4j2.xml has now been updated in the docker PR, this class and SessionAppender will disappear once we're embedded-only, and branch time is quickly approaching, I'm going to leave it like this for now. We can clean up the logging package in a subsequent PR if we want to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
@labkey-willm flagged a log4j2 error on Tomcat standalone which pointed out that this class is in the wrong package for that deployment scenario
Related Pull Requests