Skip to content

Support record binding from API actions using JSON - #7837

Merged
labkey-adam merged 10 commits into
developfrom
fb_json_records
Jul 14, 2026
Merged

Support record binding from API actions using JSON#7837
labkey-adam merged 10 commits into
developfrom
fb_json_records

Conversation

@labkey-adam

@labkey-adamlabkey-adam commented Jul 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Rationale

We want more actions to support form binding to Java records. https://github.com/LabKey/internal-issues/issues/1277

Related Pull Requests

labkey-matthewb
labkey-matthewb reviewed Jul 13, 2026
View reviewed changes
Comment threadapi/src/org/labkey/api/action/BaseViewAction.java Outdated
labkey-matthewb
labkey-matthewb requested changes Jul 13, 2026
View reviewed changes

@labkey-matthewblabkey-matthewb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spent a lot of time chasing down errors that change depending on the exact code path. I'd like to see a small record/class test that shows that the errors are the same.

@labkey-adam

labkey-adam commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

I've spent a lot of time chasing down errors that change depending on the exact code path. I'd like to see a small record/class test that shows that the errors are the same.

They are probably as aligned as they're going to get. See BindingTestCase.

Of course, the missing parameter error does not apply to form beans, since these members are always initialized to their default values. The conversion error is now consistent across both, though.

@labkey-adam
labkey-adam merged commit 6d03722 into developJul 14, 2026
8 checks passed
@labkey-adam
labkey-adam deleted the fb_json_records branch July 14, 2026 23:22
@labkey-adamlabkey-adam mentioned this pull request Jul 15, 2026
Merged
labkey-adam added a commit that referenced this pull request Jul 15, 2026
@labkey-adam
Tweaks to record binding (#7849)
c7e5e7b
## Rationale
Claude had some late-breaking suggestions for record binding, primarily
if validate() is implemented (not currently, but could be added in the
future) then propagating new Object() as the target would result in a
ClassCastException.
Note that, if a record is used, getView() in the reshow case needs to
handle a null target.
## Related Pull Requests
- #7837
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-matthewblabkey-matthewblabkey-matthewb approved these changes
@labkey-jeckelslabkey-jeckelsAwaiting requested review from labkey-jeckels

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-adam@labkey-matthewb