Skip to content

Issue 1324: Pass through audit comments to ExperimentListener on sample type and source type deletion - #7934

Merged
labkey-susanh merged 8 commits into
developfrom
fb_workflowExpListener
Aug 17, 2026
Merged

Issue 1324: Pass through audit comments to ExperimentListener on sample type and source type deletion#7934
labkey-susanh merged 8 commits into
developfrom
fb_workflowExpListener

Conversation

@labkey-susanh

Copy link
Copy Markdown
Contributor

Rationale

Issue 1324 When a sample type or source type is deleted, the samples or sources should be removed from any jobs that reference them since otherwise those job entities become orphaned, showing up in counts but never surfacing in the UI with no way for users to get rid of them. We want to pass through the audit comment provided for the type deletion.

Related Pull Requests

Changes

  • Update signature of beforeMaterialDelete and beforeDataDelete to accept a nullable auditUserComment
  • Add transactionId to the DomainEvents audit table (where source type deletions are recorded)

Comment threadexperiment/src/org/labkey/experiment/api/ExperimentServiceImpl.java Outdated
Comment threadexperiment/src/org/labkey/experiment/api/SampleTypeServiceImpl.java Outdated
@labkey-susanh
labkey-susanh merged commit e307b80 into developAug 17, 2026
7 of 8 checks passed
@labkey-susanh
labkey-susanh deleted the fb_workflowExpListener branch August 17, 2026 22:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-susanh@XingY