Skip to content

Fix black rectangles in QC plot SVG and PDF exports#1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankurjuneja wants to merge 2 commits into
base:release26.7-SNAPSHOT
Choose a base branch
from
Open

Fix black rectangles in QC plot SVG and PDF exports #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8278813
Fix black rectangles in QC plot SVG and PDF exports
ankurjuneja Aug 20, 2026
6d6da58
fix test failure
ankurjuneja Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions webapp/TargetedMS/js/QCPlotHelperBase.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1150,7 +1150,7 @@ Ext4.define("LABKEY.targetedms.QCPlotHelperBase", {
.attr('y', gridTop)
.attr('width', overlayW)
.attr('height', gridBottom - gridTop)
.style({'fill': 'transparent', 'cursor': isZoomed ? 'zoom-out' : 'zoom-in'});
.style({'fill': '#ffffff', 'fill-opacity': 0, 'pointer-events': 'all', 'cursor': isZoomed ? 'zoom-out' : 'zoom-in'});

if (isZoomed) {
overlayEl.on('click', function() { me.resetYZoom(plotId, axis); });
Expand DownExpand Up@@ -1181,7 +1181,7 @@ Ext4.define("LABKEY.targetedms.QCPlotHelperBase", {
.attr('x', 0).attr('y', 0)
.attr('width', parseFloat(svg.attr('width')) || (gridRight + 80))
.attr('height', parseFloat(svg.attr('height')) || (gridBottom + 50))
.style({'fill': 'transparent', 'pointer-events': 'all', 'cursor': 'default'});
.style({'fill': '#ffffff', 'fill-opacity': 0, 'pointer-events': 'all', 'cursor': 'default'});

zoomButtonGroup = svg.append('g').attr('class', 'y-zoom-buttons');

Expand DownExpand Up@@ -1254,7 +1254,7 @@ Ext4.define("LABKEY.targetedms.QCPlotHelperBase", {
plotClickCapture = svg.append('rect')
.attr('x', gridLeft).attr('y', gridTop)
.attr('width', gridRight - gridLeft).attr('height', gridBottom - gridTop)
.style({'fill': 'transparent', 'cursor': 'crosshair'})
.style({'fill': '#ffffff', 'fill-opacity': 0, 'pointer-events': 'all', 'cursor': 'crosshair'})
.on('click', function() {
let clickY = clampY(d3.mouse(svg.node())[1]);
let firstY = pendingStartY;
Expand Down
6 changes: 3 additions & 3 deletions webapp/TargetedMS/js/QCTrendPlotPanel.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1639,7 +1639,7 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
if (!d || !d.name || d.separator) return;
let isHidden = !!(hidden[d.hoverText || d.name.split(LABKEY.targetedms.QCPlotHelperBase.SERIES_NAME_SEP)[0]]);
let item = d3.select(this);
item.select('path').attr('fill', isHidden ? 'transparent' : (d.color || null));
item.select('path').attr('fill', d.color || null).attr('fill-opacity', isHidden ? 0 : null);
item.select('text').attr('opacity', isHidden ? 0.3 : 1);
item.select('.legend-check').remove();
if (!isHidden) {
Expand DownExpand Up@@ -1688,7 +1688,7 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
let isHidden = !!hidden[frag];
let isActive = d.name.indexOf(fragment + (hasYRightMetric ? LABKEY.targetedms.QCPlotHelperBase.SERIES_NAME_SEP : '')) === 0;
let item = d3.select(this);
item.select('path').attr('fill', isHidden ? 'transparent' : (d.color || null));
item.select('path').attr('fill', d.color || null).attr('fill-opacity', isHidden ? 0 : null);
item.select('text').attr('opacity', isHidden ? 0.1 : (isActive ? 1 : 0.1));
});

Expand DownExpand Up@@ -1779,7 +1779,7 @@ Ext4.define('LABKEY.targetedms.QCTrendPlotPanel', {
if (!d || !d.name || d.separator) return;
let isHidden = !!hidden[d.hoverText || d.name.split(LABKEY.targetedms.QCPlotHelperBase.SERIES_NAME_SEP)[0]];
let item = d3.select(this);
item.select('path').attr('fill', isHidden ? 'transparent' : (d.color || null));
item.select('path').attr('fill', d.color || null).attr('fill-opacity', isHidden ? 0 : null);
item.select('text').attr('opacity', isHidden ? 0.3 : 1);
item.select('.legend-check').remove();
if (!isHidden) {
Expand Down
Loading