Skip to content

Fb qc notifications - #4

Merged
labkey-ankurj merged 19 commits into
developfrom
fb_qcNotifications
Jun 26, 2019
Merged

Fb qc notifications#4
labkey-ankurj merged 19 commits into
developfrom
fb_qcNotifications

Conversation

@labkey-ankurj

@labkey-ankurjlabkey-ankurj commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

No description provided.

labkey-jeckelsand others added 11 commits May 29, 2019 14:57
labkey-jeckelslabkey-jeckels
ASMS poster prep:
809e901
Improve layout of QC Summary web part, including showing both sample name and acquisition time in a table layout.
Improve layout of email content, and make it a little more real in terms of subject, sender, etc.
Tweak layout and wording of QC notification subscription and metric selection UIs
Add column to track future support of run-scoped metrics
@labkey-ankurj
Merge branch 'develop' into fb_qcNotifications
90e24a8
@labkey-ankurj
Item 5203: Include call to outlier identification in DataHandler
376c25c
@labkey-ankurj
Issue 37304: When there is no guide set for QC Plots, there should be…
033bf7b
… a default guide set with all data points on the qc plot.
@labkey-jeckelslabkey-jeckels
Fix a bunch of TargetedMS tests. TargetedMSTable wasn't actually immu…
553a682
…table, which made it quite unsafe to cache. Now it is, and we can use a ContainerFilter (already handled via the caching code) to control the lookup behavior to get the same optimized query generated.
labkey-jeckelslabkey-jeckels
Show outlier totals by metrics in summary grid
55710e9
@labkey-ankurj
Item 5203: Add custom QueryUpdateService
90ed032
@labkey-ankurj
Merge remote-tracking branch 'origin/fb_qcNotifications' into fb_qcNo…
6aeb119
…tifications
labkey-jeckelslabkey-jeckels
Fix query to work on Postgres
1d94151
@labkey-ankurj
Item 5203: show subscriptions only to admins
0ec040e
@labkey-ankurj
Merge remote-tracking branch 'origin/fb_qcNotifications' into fb_qcNo…
7089de6
…tifications
labkey-jeckels
labkey-jeckels requested changes Jun 7, 2019
View reviewed changes
Comment threadapi-src/org/labkey/api/targetedms/SkyLineDocumentImportListener.java Outdated
Comment threadapi-src/org/labkey/api/targetedms/TargetedMSService.java Outdated
Comment threadapi-src/org/labkey/api/targetedms/model/SampleFileInfo.java
}

public JSONObject toJSON(){
JSONObject jsonObject = new JSONObject();

@labkey-jeckelslabkey-jeckelsJun 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to use Jackson to auto-convert this to JSON

@labkey-ankurjlabkey-ankurjJun 9, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will discuss this tomorrow.

Comment threadresources/schemas/targetedms.xml Outdated
labkey-jeckels
labkey-jeckels requested changes Jun 9, 2019
View reviewed changes

@labkey-jeckelslabkey-jeckels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Added one more suggestion about migrating the table for the subscriptions, and saw your note about talking about the JSON serialization.

Comment threadresources/schemas/dbscripts/sqlserver/targetedms-19.16-19.17.sql Outdated
labkey-jeckels
labkey-jeckels requested changes Jun 11, 2019
View reviewed changes
Comment threadresources/schemas/dbscripts/sqlserver/targetedms-19.17-19.18.sql Outdated
labkey-jeckels
labkey-jeckels requested changes Jun 17, 2019
View reviewed changes

@labkey-jeckelslabkey-jeckels left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to wrong PR

labkey-jeckels
labkey-jeckels requested changes Jun 21, 2019
View reviewed changes
Comment threadresources/schemas/dbscripts/postgresql/targetedms-19.19-19.20.sql
Comment threadsrc/org/labkey/targetedms/TargetedMSModule.java Outdated
@labkey-jeckelslabkey-jeckels mentioned this pull request Jun 21, 2019
Merged
@labkey-ankurj
labkey-ankurj merged commit 5781856 into developJun 26, 2019
@labkey-ankurj
labkey-ankurj deleted the fb_qcNotifications branch June 26, 2019 15:41
nickshulman pushed a commit to nickshulman/targetedms that referenced this pull request Jan 31, 2021
@labkey-susanh
gradlePluginsVersion 1.20.0 (LabKey#4)
f854146
@labkey-jeckelslabkey-jeckels mentioned this pull request Jun 6, 2026
Merged
@labkey-jeckelslabkey-jeckels mentioned this pull request Jul 27, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckelslabkey-jeckelslabkey-jeckels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-ankurj@labkey-jeckels@vagisha