Skip to content

Refactor DataRegionTable to handle tricky characters better - #2513

Merged
labkey-tchad merged 8 commits into
developfrom
fb_dataRegionRefactor
Jun 27, 2025
Merged

Refactor DataRegionTable to handle tricky characters better#2513
labkey-tchad merged 8 commits into
developfrom
fb_dataRegionRefactor

Conversation

@labkey-tchad

@labkey-tchadlabkey-tchad commented Jun 25, 2025

Copy link
Copy Markdown
Member

Rationale

DataRegionTable doesn't actually handle field names with tricky characters. What it calls field names are actually fieldKeys. This update adopts a similar pattern to the recent app grid test update. I had to replicate some existing non-standard behavior to avoid breaking existing tests (removing spaces from fieldKeys and ignoring spaces when looking up field labels).

Related Pull Requests

Changes

  • Update DataRegionTable to use FieldReferenceManager.java to organize and identify columns
  • Clean up numerous IntelliJ warnings
  • Remove usages of some deprecated DataRegionTable methods

@labkey-chrisjlabkey-chrisj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Comment threadsrc/org/labkey/test/tests/AbstractExportTest.java
Comment threadsrc/org/labkey/test/tests/DatasetExportTest.java
Comment threadsrc/org/labkey/test/tests/TimeChartAPITest.java Outdated
Comment threadsrc/org/labkey/test/util/CachingSupplier.java
Comment threadsrc/org/labkey/test/util/DataRegionTable.java
Comment threadsrc/org/labkey/test/util/DataRegionTable.java
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-tchad@labkey-danield@labkey-chrisj