Skip to content

Disable email recording when verifying timeouts - #3167

Merged
labkey-adam merged 3 commits into
release26.7-SNAPSHOTfrom
26.7_fb_disable_dumbster
Aug 24, 2026
Merged

Disable email recording when verifying timeouts#3167
labkey-adam merged 3 commits into
release26.7-SNAPSHOTfrom
26.7_fb_disable_dumbster

Conversation

@labkey-adam

@labkey-adamlabkey-adam commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Rationale

AdminConsoleTest.testEmailTimeoutSettings() started failing intermittently in 26.8+, showing that the timeout settings were not always present. This test is passing regularly in 26.7. I believe a small MailHelper refactor in 26.8 caused a change in behavior; now, when email recording is on, the "test email" page shows the dumbster configuration (which lacks timeout properties) instead of the application.properties configuration (which includes them by default). This is likely the behavior we want in the "test email" page, so this changes the test to shut off email recording if it's on. And then restores it after verifying.

The change is not technically needed for 26.7, but it doesn't hurt to disable/re-enable there.

Also, "admin" is not a module, so remove that reference from AbstractAdminConsoleTest.java.

Related Pull Requests

Tasks 📍

  • Claude Code Review
  • Code Review @labkey-tchad
  • TeamCity Review and Merge
  • Merge Test Fix to 26.8? no need
  • Verify Test Fix (once merged forward) @labkey-tchad

@labkey-tchadlabkey-tchad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to remember the existing dumbster setting. Any test that cares about capturing emails needs to call enableEmailRecorder just to clear out the email record.

@labkey-adamlabkey-adam self-assigned this Aug 24, 2026
@labkey-adam
labkey-adam merged commit 607206d into release26.7-SNAPSHOTAug 24, 2026
6 checks passed
@labkey-adam
labkey-adam deleted the 26.7_fb_disable_dumbster branch August 24, 2026 20:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-adam@labkey-tchad