Skip to content

[Infra] .gitignore says never commit test_snapshots, but 5 snapshot files are tracked #584

Description

@ogazboiz

Telegram: https://t.me/+DOylgFv1jyJlNzM0

Why this matters

.gitignore contains:

# Soroban test runner — auto-generated, never commit
**/test_snapshots/

…yet git ls-files shows 5 tracked files under contracts/stream_contract/test_snapshots/test/*.json (the directory itself contains ~100 generated snapshots, most correctly untracked). This is contradictory: either these 5 were committed before the ignore rule and should be removed from tracking, or snapshots are intentionally version-controlled and the ignore rule/comment is wrong. The inconsistency causes churn (untracked vs tracked snapshots) and confuses contributors.

Acceptance criteria

  • Decide whether Soroban test snapshots are committed or ignored
  • If ignored: git rm --cached the 5 tracked snapshot JSONs so the tree matches .gitignore
  • If committed: remove/adjust the **/test_snapshots/ ignore rule and document the policy
  • git status is clean and consistent after a fresh cargo test

Files to touch

  • .gitignore
  • contracts/stream_contract/test_snapshots/ (the 5 tracked files)

Out of scope

  • Contract test logic.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programcontractsSmart contract related tasksgood first issueGood for newcomersinfraCI/CD and infrastructure

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions