Skip to content

[Frontend] Settings page labels lack htmlFor — Default Token / Amount Format / Decimal Places #630

Description

@ogazboiz

Join the discussion on Telegram

Why this matters

Three <label> elements in the settings page have no htmlFor attribute and no associated id on the control, so screen readers can't announce which control each label belongs to:

frontend/src/app/settings/page.tsx:

  • Line 246: <label className=\"text-sm ...\">Default Token</label> → associated <select> at line 247 has no id
  • Line 263: <label ...>Amount Format</label> → the buttons it labels at lines 265-281 are not associated
  • Line 285: <label ...>Decimal Places</label> → same situation for buttons at lines 287-303

Issue #559 covered modal role=dialog/aria-modal, and #465 covered icon-only buttons — neither addressed these specific labels.

Acceptance criteria

  • Default Token label → add htmlFor and put a matching id on the <select> (or use a wrapping <label> that contains the control)
  • Amount Format label → wrap the button group with a role=\"radiogroup\" and use aria-labelledby to point at the label
  • Decimal Places label → same pattern as Amount Format

Files to touch

  • frontend/src/app/settings/page.tsx (lines 246-307)

Out of scope

  • Adding new settings fields

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programfrontendFrontend related tasksgood first issueGood for newcomersuiUser interface refinement

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions