refactor(worker): replace transaction any types - #759
Conversation
|
heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: |
|
clean type-only improvement (tx: any -> Prisma.TransactionClient). the red is the same unrelated backend auth test, tsc passes. stale base, rebase: |
|
closing as superseded: the worker was rewritten and current soroban-event-worker.ts has typed tx params throughout, no any left to replace. 30 days without a response to the july 4 feedback. if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0 |
Description
Replace
anytransaction client types in the Soroban event worker with Prisma's generatedTransactionClienttype to improve compile-time type safety.Type of Change
Related Issues
Closes #633
Changes Made
tx: anywithtx: Prisma.TransactionClientinensureSystemStreamtx: anywithtx: Prisma.TransactionClientin all Prisma transaction callbacksTesting
Test Coverage
Test Steps
npm run buildPrisma.TransactionClientBreaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
N/A
Checklist
Additional Notes
Prisma.TransactionClientallows TypeScript to validate transaction-scoped Prisma operations and catch typos or invalid model access during compilation.