Skip to content

fix(#621): remove unused API_BASE_URL declaration from dashboard.ts - #963

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
shogun444:fix/remove-api-base-url-621
Jul 1, 2026
Merged

fix(#621): remove unused API_BASE_URL declaration from dashboard.ts#963
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
shogun444:fix/remove-api-base-url-621

Conversation

@shogun444

Copy link
Copy Markdown
Contributor

Closes #621

Changes

  • Removed the unused \API_BASE_URL\ module-level constant from \ rontend/src/lib/dashboard.ts\ that was declared but never referenced.
  • Verified with ESLint that no other references exist.

@shogun444
shogun444 force-pushed the fix/remove-api-base-url-621 branch from 4ef2e9b to a8b0ae3 Compare June 30, 2026 07:57
@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

your branch is green, but it went conflicting after the ci fixes landed on main: #969 and #974 touched backend/Dockerfile and backend/src/workers/soroban-event-worker.ts, which this pr also edits. please rebase on main and it should be good to go: git fetch origin && git rebase origin/main && git push --force-with-lease. if any of your Dockerfile or soroban-event-worker changes overlap what #969 already did (copying prisma/ into the runner, and the import type { Prisma } from '../generated/prisma' fix), drop those now-redundant bits and keep just your actual change. i'll re-review and merge once it's rebased and ci is green.

@shogun444
shogun444 force-pushed the fix/remove-api-base-url-621 branch from 6fa2cfe to d6b8a09 Compare July 1, 2026 05:13
@shogun444

Copy link
Copy Markdown
Contributor Author

@ogazboiz Rebased on main and dropped the redundant backend changes (#969 already covers them). Ready for re-review. CI is green.

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed API_BASE_URL isn't referenced anywhere, this just drops the dead line in dashboard.ts. safe. (heads up the title mentions removing a constant but the diff is only a blank-line removal, there's no constant, harmless.) merging.

@ogazboiz
ogazboiz merged commit 966cabf into LabsCrypt:main Jul 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Remove dead API_BASE_URL in lib/dashboard.ts (declared but never used)

2 participants