Skip to content

Missing a comma! - #2

Closed
ricaun wants to merge 1 commit into
LacunaSpace:work-in-progressfrom
ricaun:patch-1
Closed

Missing a comma!#2
ricaun wants to merge 1 commit into
LacunaSpace:work-in-progressfrom
ricaun:patch-1

Conversation

@ricaun

Copy link
Copy Markdown

Missing a comma!

debug_verbose_printf("Updating info for TX at %F, airtime will be %F, frequency %.2F.\r\n", txbeg, 0airtime, 0, LMIC.freq, 6);

@matthijskooijman

Copy link
Copy Markdown
Contributor

Thanks for your pull request!

I've been fixing more stuff and doing some significant git history cleanups of the code, so I included this fix in the original that introduced the breakage. I pushed that to master, which I am intending to keep stable (i.e. without force pushes) from now on.

This fix should be present in master, so I'm closing this PR :-)

@ricaun

Copy link
Copy Markdown
Author

Hello,

The last time I compiled your code in the Arduino library.
https://github.com/ricaun/arduino-BasicMAC

The sx127x works ok but the sx126x I have some problem with the Dio3. My board does not have the DIO3 to drive connected to the crystal, and the code forces to use dio3 on SetDIO3AsTcxoCtrl .

I was trying to use US915 but the code has some bug on a REG_FIX, the join does not work very well.

I noticed the original code has updated to version a final release 2.2
https://github.com/lorabasics/basicmac

And a lot of the code change, like the nextJoinState has some update and the SetDIO3AsTcxoCtrl does not exist anymore.

See yaa.

@matthijskooijmanmatthijskooijman mentioned this pull request Apr 16, 2020
@matthijskooijman

Copy link
Copy Markdown
Contributor

I moved your comment to a new issue, I'll reply there :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ricaun@matthijskooijman