F-041 (P6) — Dead telemetry name constants: `TelemetryLogPropertyNames` entirely unused

[LarsLaskowski]

Severity: 🟡 · Criterion: K11 / K9 · Phase: P6 · Status (review): 🆕

File(s): src/DockerUpdateGuard.Telemetry/TelemetryLogPropertyNames.cs (entire); cross-reference actual log templates src/DockerUpdateGuard/HostLoggingExtensions.cs:47-56 and the remaining *LoggingExtensions

Finding

The class TelemetryLogPropertyNames (eight constants, some aliases of
TelemetryTagNames) is referenced nowhere in production code (repo-wide search for
TelemetryLogPropertyNames. → empty). Structured logging runs throughout via
source-generated [LoggerMessage] templates with ad-hoc named placeholders
(e.g. {ObservedImages}, {RuntimeContainers} in HostLoggingExtensions.cs:49), not
via these central property names. The intended "shared, centrally maintained
property naming convention" is thus not realized. (Sibling to
F-040:``
there too, activity/tag names are only partially wired up.)

Impact

Dead code that suggests a consistency that does not exist; log property
names drift apart between the *LoggingExtensions (no single source of truth).
Purely maintainability/convention-related, no runtime error.

Recommendation

Either switch the [LoggerMessage] templates to the central names
(for stable, correlatable log attributes across the OTLP logging pipeline) or remove the unused
class + unused TelemetryTagNames/TelemetryActivityNames members.

---

_{Auto-generated from the repository code review. Source of truth: docs/review/findings.md → F-041 (P6), branch review/review-analysis-plan.}