fix(dag): reject ungated reporting checkpoints at authoring - #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident (issue #320)
2026-08-17: a hand-authored 15-node DAG ran 75 minutes to
completedalthough every decision checkpoint returnedverdict: replan. Five checkpoint/stage pairs were wired withdepends_ononly — nocondition— so each next stage spawned ~12ms after its checkpoint settled. Thereport_to_parentwake to the parent was terminal-only advisory signal, never a gate.Design decisions
report_to_parent: truenode with dependents is a reporting checkpoint; each dependent must gate on its output viacondition(input_mapping does not count), or the checkpoint must be a reporting leaf, or the node must dropreport_to_parent.node_defaults.report_to_parentis honored.checkpointGateDiagnosticswired ONLY intovalidatePostCompile's structural branch — the authoring start/validate path. Each ungated dependent emits one error-severitydag.invaliddiagnostic in bothportableandenvironmentprofiles.Dag.create/replan/extend paths untouched to preserve wake-chain + reopen-extend semantics (issue spec(dag): unblock the REJECT checkpoint — a rejected review completes the workflow (A1) #294).gatefield (conditionalready expresses gating).Docs
CONTEXT.md: Reporting Checkpoint glossary row + gating invariant.Acceptance evidence
test/dag/dag-checkpoint-gate.test.ts, all passing.bun typecheckclean (tsgo --noEmit).ultra-flow-route.yaml+release-route.yamlhit, tracked in opencode-dag-config#14.