fix(dag): build DagSupervisionSweep in the server app graph - #358
Merged
Conversation
The host-level deadline supervision sweep was constructed only in AppLayer; the desktop sidecar calls Server.listen without effectCmd, so AppLayer never existed there and orphaned-node supervision never ran on the desktop default path. Every serving process builds the server app graph once per listener — listing the sweep node here covers serve/web/TUI/sidecar alike. Processes that also build AppLayer get a second instance; settle is convergent (workflow lock + guardNode + conditional projector UPDATE), so the duplicate is safe. Closes#341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#341
What
DagSupervisionSweep.nodeadded to the server app group (server.ts). The desktop sidecar (packages/desktop/src/main/sidecar.ts) callsServer.listenwithout effectCmd — AppLayer never exists there, so the sweep (2026-08-18 orphaned-nodes incident response) never ran on the desktop default path. Every serving process builds the app graph once per listener, which now includes the sweep (fiber lives in the listener scope).Database/DagStore/Dag/SessionPromptnodes) resolve via the sweep node's own dependency list within the shared buildLayer cache.test/server/httpapi-sweep-wiring.test.ts(presence + recorder replacement resolving through the app-graph output).Verification
bun run typecheckgreen (packages/opencode)bun test test/server/httpapi-sweep-wiring.test.ts2/2Note:
test/dag/dag-node-supervision.test.tshas 3 wall-clock-sensitive cases (5s budgets) that fail on this loaded local machine atf25f37d7etoo (pre-dating this change, no runtime code between); CI (green atcb17d3ca) is the arbiter.