fix(dag): crash recovery preserves a schemaless node's string verdict - #362
Merged
Conversation
The recovery path completed a schemaless running node with undefined and
never read the child session's messages, while the live path settles with the
last assistant text — a crash between the child's final reply and the
NodeCompleted publish erased the outcome: a bare {"verdict":"replan"}
checkpoint reply lost its veto (no pause, no warning) and gated dependents
resolved no fields. Recovery now mirrors the live path via an injected
last-assistant-text reader; an explicitly unparseable workflow row (null) fails
the node loudly instead of undefined-completing past settleCapturedOutput.
Closes#345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#345
What
reconcileWorkflowtakes an injectedlastAssistantTextreader (makeLastAssistantTextReader(sessions), provided by DagLoop) and settles with the child's last assistant text (""floor, exactly likespawn.ts). A crash between the child's final reply and the NodeCompleted publish no longer erases a string verdict — a bare{"verdict":"replan"}checkpoint keeps its veto, gated dependents resolve fields, input_mapping stops degrading to placeholders.parseWorkflowConfig(wf.config) ?? null) fails the node loudly (exec_failed, counted as ownershipLost so P2-2 recovery-pause applies) instead of undefined-completing a schema-carrying node pastsettleCapturedOutput.Tests
""(live-path parity)